From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Thu, 10 Jan 2019 10:20:18 +0100 Subject: [U-Boot] [GIT] Pull request: u-boot-dfu (10.01.2019) In-Reply-To: <95d9e0d7-d2d1-9ca1-9409-179a30837cf8@denx.de> References: <20190110002149.58cfa3f8@jawa> <50475473-7e3d-8804-5b0a-6043ccfa2ac3@denx.de> <20190110083754.64e81da5@jawa> <95d9e0d7-d2d1-9ca1-9409-179a30837cf8@denx.de> Message-ID: <20190110102018.3cba22f7@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Marek, Jean-Jacques > On 1/10/19 8:37 AM, Lukasz Majewski wrote: > > On Thu, 10 Jan 2019 01:53:23 +0100 > > Marek Vasut wrote: > > > >> On 1/10/19 12:21 AM, Lukasz Majewski wrote: > >>> Dear Marek, > >>> > >>> I've build tested the patch set from Jean-Jacques on sunxi: > >>> > >>> ./tools/buildman/buildman.py --branch=HEAD sunxi --detail > >>> --verbose --show_errors --force-build --count=5 > >>> --output-dir=../BUILD/ > >>> > >>> It also passes on Travis-CI: > >>> https://travis-ci.org/lmajewski/u-boot-dfu/builds/477104303 > >>> > >>> The following changes since commit > >>> 7436f5e54d35bcad53befec90e2e67288071f74e: > >>> > >>> Merge tag 'for-master-20190103' of > >>> git://git.denx.de/u-boot-rockchip (2019-01-03 08:39:44 -0500) > >>> > >>> are available in the git repository at: > >>> > >>> git://git.denx.de/u-boot-dfu.git > >>> > >>> for you to fetch changes up to > >>> 97f2e6987887777eba9ee0ea51b3c2f34e989788: > >>> > >>> dm: usb: gadget: Fix boot breakage on sunxi platforms > >>> (2019-01-09 01:04:36 +0100) > >>> > >>> ---------------------------------------------------------------- > >>> Jean-Jacques Hiblot (5): > >>> dm: usb: udc: Use SEQ_ALIAS to index the USB gadget ports > >>> ARM: dts: define USB aliases for all omap5 platforms > >>> Kconfig: rename CONFIG_SPL_USB_GADGET_SUPPORT as > >>> CONFIG_SPL_USB_GADGET > >>> usb: Make compiling gadget support optional > >>> dm: usb: gadget: Fix boot breakage on sunxi platforms > >> > >> I think that's the wrong patch at the end, it still unconditionally > >> pulls in udc-uclass.o if CONFIG_$(SPL_)DM is enabled. > >> > > > > This is the order proposed by Jean-Jacques: > > > > Just changing the order should be enough to prevent any breakage. > > > > 1) Kconfig: rename CONFIG_SPL_USB_GADGET_SUPPORT as > > CONFIG_SPL_USB_GADGET > > 2) usb: Make compiling gadget support optional > > 3) dm: usb: gadget: Fix boot breakage on sunxi platforms > > But it's still unconditionally pulling in UDC code if DM is enabled, > which is what I was complaining in the previous PR too , can you > explain why ? > I thought that this rename solves this issue. However, Jean-Jacques could you provide explanation to the above question? Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: