From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly
Date: Thu, 10 Jan 2019 10:47:37 +0100 [thread overview]
Message-ID: <20190110104737.242eaae3@jawa> (raw)
In-Reply-To: <485a4d93-4536-5164-9115-6eb61a3cc6ab@denx.de>
On Thu, 10 Jan 2019 10:34:21 +0100
Stefano Babic <sbabic@denx.de> wrote:
> Hi Lukasz,
>
> On 10/01/19 10:29, Lukasz Majewski wrote:
> > Hi Stefano,
> >
>
> [snip]
>
> >> There is a topic I would like to check. Stefan introduces with his
> >> patches a DDRMC_CR80_MC_INIT_COMPLETE that is still missing in your
> >> patches. I solved the conflict (not yet pushed to -next) as :
> >>
> >> while (!(readl(&ddrmr->cr[80]) & DDRMC_CR80_MC_INIT_COMPLETE))
> >> udelay(10);
> >> writel(DDRMC_CR80_MC_INIT_COMPLETE, &ddrmr->cr[81]);
> >>
> >> #ifdef CONFIG_DDRMC_VF610_CALIBRATION
> >> ddrmc_calibration(ddrmr);
> >> #endif
> >>
> >> But I have no idea if DDRMC_CR80_MC_INIT_COMPLETE should be done
> >> before the calibration of maybe after. Could you help me ?
> >
> > I've already rebased (DDR calibration code) on top of Stefan's
> > patches:
> >
> > http://git.denx.de/?p=u-boot/u-boot-dfu.git;a=shortlog;h=refs/heads/testing
> >
> > The code in question looks like in below link:
> > http://git.denx.de/?p=u-boot/u-boot-dfu.git;a=blob;f=arch/arm/mach-imx/ddrmc-vf610.c;h=9a8e2f6aad10adc45fa791d24ffad52c42c5c492;hb=refs/heads/testing#l231
>
> ok, thanks - so the DDRMC_CR80_MC_INIT_COMPLETE is called before
> calibration. I have already did this by rebasing myself. There is no
> need you repost, I have merged yours patches into my -next branch.
>
Thanks :-) (And I do have more vf610 patches in the queue to move it to
DM - as it uses only single u-boot binary).
I will post them when we release v2019.01
> Regards,
> Stefano
>
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190110/262ab093/attachment.sig>
prev parent reply other threads:[~2019-01-10 9:47 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 13:53 [U-Boot] [PATCH v1] tools: logos: crop Toradex logo slightly Stefan Agner
2018-12-06 14:41 ` Lukasz Majewski
2018-12-08 16:48 ` Lukasz Majewski
2018-12-14 13:13 ` Stefan Agner
2018-12-14 13:20 ` Tom Rini
2018-12-14 13:26 ` Stefan Agner
2018-12-14 13:30 ` Tom Rini
2018-12-14 13:40 ` Stefano Babic
2019-01-04 15:05 ` Stefan Agner
2019-01-09 15:41 ` Stefano Babic
2019-01-09 21:38 ` Lukasz Majewski
2019-01-10 8:15 ` Stefano Babic
2019-01-10 9:29 ` Lukasz Majewski
2019-01-10 9:34 ` Stefano Babic
2019-01-10 9:47 ` Lukasz Majewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190110104737.242eaae3@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox