U-Boot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] spl: implement CRC check on U-Boot uImage
Date: Mon, 14 Jan 2019 11:27:53 -0500	[thread overview]
Message-ID: <20190114162753.GL5463@bill-the-cat> (raw)
In-Reply-To: <1a41a5df-e82e-6cfb-e50f-dc5425fc61ec@gmail.com>

On Mon, Jan 14, 2019 at 04:38:24PM +0100, Simon Goldschmidt wrote:
> Tom,
> 
> Am 11.12.2018 um 02:07 schrieb Simon Glass:
> >On Wed, 28 Nov 2018 at 13:52, Simon Goldschmidt
> ><simon.k.r.goldschmidt@gmail.com> wrote:
> >>
> >>SPL currently does not check uImage CRCs when loading U-Boot.
> >>
> >>This patch adds checking the uImage CRC when SPL loads U-Boot. It does
> >>this by reusing the existing config option SPL_CRC32_SUPPORT to allow
> >>leaving out the CRC check on boards where the additional code size or
> >>boot time is a problem (adding the CRC check currently adds ~1.4 kByte
> >>to flash).
> >>
> >>The SPL_CRC32_SUPPORT config option now gets enabled by default if SPL
> >>support for legacy images is enabled to check the CRC on all boards
> >>that don't actively take countermeasures.
> >>
> >>Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> >>---
> >>
> >>Changes in v2:
> >>- added Kconfig option SPL_LEGACY_IMAGE_CRC_CHECK to enable/disable
> >>   checking CRC on legacy images
> >>
> >>  common/spl/Kconfig | 21 +++++++++++++++------
> >>  common/spl/spl.c   | 30 +++++++++++++++++++++++++++++-
> >>  include/spl.h      |  5 +++++
> >>  3 files changed, 49 insertions(+), 7 deletions(-)
> >
> >Reviewed-by: Simon Glass <sjg@chromium.org>
> 
> This is assigned to you in patchwork, any reason you did not add it for the
> 2019.01 release? Is there anything missing or was this just lost?

I think I might have filed this off mentally as "Did we still want to do
this?", so I'll pick it up for the next release, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190114/bcdf3c72/attachment.sig>

  reply	other threads:[~2019-01-14 16:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-28 20:52 [U-Boot] [PATCH v2] spl: implement CRC check on U-Boot uImage Simon Goldschmidt
2018-12-11  1:07 ` Simon Glass
2019-01-14 15:38   ` Simon Goldschmidt
2019-01-14 16:27     ` Tom Rini [this message]
2019-02-01 18:55       ` Simon Goldschmidt
2019-02-08 19:46 ` [U-Boot] [U-Boot,v2] " Tom Rini
2019-02-08 21:05   ` Simon Goldschmidt
2019-02-08 21:19     ` Tom Rini
2019-02-09 21:56       ` Simon Goldschmidt
2019-02-10  0:43         ` Tom Rini
2019-02-10 13:07           ` Simon Goldschmidt
2019-02-10 13:23             ` Tom Rini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190114162753.GL5463@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox