From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 15 Jan 2019 09:28:14 -0500 Subject: [U-Boot] configs: Enable CONFIG_BLK in a few TI boards In-Reply-To: <20190108124631.29201-1-faiz_abbas@ti.com> References: <20190108124631.29201-1-faiz_abbas@ti.com> Message-ID: <20190115142814.GA12472@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Jan 08, 2019 at 06:16:31PM +0530, Faiz Abbas wrote: > With DM conversion completed, enable CONFIG_BLK for a > few pending TI boards. > > Signed-off-by: Faiz Abbas > Reviewed-by: Lokesh Vutla > --- > configs/am335x_boneblack_vboot_defconfig | 1 - > configs/am335x_evm_defconfig | 1 - > configs/am335x_hs_evm_defconfig | 1 - > configs/am335x_hs_evm_uart_defconfig | 1 - > configs/am43xx_evm_defconfig | 1 - > configs/am43xx_evm_qspiboot_defconfig | 1 - > configs/am43xx_evm_rtconly_defconfig | 1 - > configs/am43xx_evm_usbhost_boot_defconfig | 1 - > configs/am43xx_hs_evm_defconfig | 1 - > configs/am57xx_evm_defconfig | 1 - > configs/am57xx_hs_evm_defconfig | 1 - > configs/k2g_evm_defconfig | 1 - > configs/k2g_hs_evm_defconfig | 1 - > 13 files changed, 13 deletions(-) So, a problem with this patch is that we can't only enable CONFIG_BLK in all cases, we also need to make sure that if we have MMC we have DM_MMC and if we have USB we have DM_USB. This latter case is what tripped me up as am43xx_evm_usbhost_boot_defconfig will have a warning with this patch applied as SPL_USB_SUPPORT really requires CONFIG_USB_STORAGE support and that in turn depends on either (BLK==n && DM_USB==n) or (BLK==y && DM_USB==y). -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: