From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Tue, 15 Jan 2019 21:39:20 -0500 Subject: [U-Boot] [U-Boot, v4, 3/6] common: command: Rework the 'cmd is repeatable' logic In-Reply-To: <20181203215423.18772-4-boris.brezillon@bootlin.com> References: <20181203215423.18772-4-boris.brezillon@bootlin.com> Message-ID: <20190116023920.GP27429@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Mon, Dec 03, 2018 at 10:54:20PM +0100, Boris Brezillon wrote: > The repeatable property is currently attached to the main command and > sub-commands have no way to change the repeatable value (the > ->repeatable field in sub-command entries is ignored). > > Replace the ->repeatable field by an extended ->cmd() hook (called > ->cmd_rep()) which takes a new int pointer to store the repeatable cap > of the command being executed. > > With this trick, we can let sub-commands decide whether they are > repeatable or not. > > We also patch mmc and dtimg who are testing the ->repeatable field > directly (they now use cmd_is_repeatable() instead), and fix the help > entry manually since it doesn't use the U_BOOT_CMD() macro. > > Signed-off-by: Boris Brezillon > Reviewed-by: Tom Rini Applied to u-boot/master, thanks! -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: