From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2] arm: mvebu: armada-xp/37x/38x: Enable PCIe DT node
Date: Thu, 17 Jan 2019 17:18:03 -0500 [thread overview]
Message-ID: <20190117221803.GU27429@bill-the-cat> (raw)
In-Reply-To: <CAFOYHZB47xrg48Kh0=YqAy4-bdCMqMbu8Rtg5mumdFySqryE+A@mail.gmail.com>
On Fri, Jan 18, 2019 at 08:57:43AM +1300, Chris Packham wrote:
> Hi Stefan,
>
> On Fri, Jan 18, 2019 at 2:35 AM Stefan Roese <sr@denx.de> wrote:
> >
> > This patch enables the DT PCIe nodes for the Armada XP/37x/38x boards.
> > This is needed for the new DM_PCI support in the MVEBU PCIe driver.
> >
> > Signed-off-by: Stefan Roese <sr@denx.de>
> > Cc: Dirk Eibach <dirk.eibach@gdsys.cc>
> > Cc: Mario Six <mario.six@gdsys.cc>
> > Cc: Chris Packham <chris.packham@alliedtelesis.co.nz>
> > Cc: Phil Sutter <phil@nwl.cc>
> > Cc: Marek Behún <marek.behun@nic.cz>
> > Cc: VlaoMao <vlaomao@gmail.com>
> > ---
> > arch/arm/dts/armada-375.dtsi | 2 +-
> > arch/arm/dts/armada-380.dtsi | 2 +-
> > arch/arm/dts/armada-385.dtsi | 2 +-
> > arch/arm/dts/armada-xp-mv78230.dtsi | 2 +-
> > arch/arm/dts/armada-xp-mv78260.dtsi | 2 +-
> > arch/arm/dts/armada-xp-mv78460.dtsi | 2 +-
> > 6 files changed, 6 insertions(+), 6 deletions(-)
>
> I think this should be at the board level instead of the SoC. There
> are boards that don't use the pcie controller even though it's in the
> SoC. Another good reason is that this deviates from the dtsi files in
> Linux
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm/boot/dts/armada-375.dtsi#n548
Yes, we should keep these files in-sync with Linux and use -u-boot.dtsi
files (see scripts/Makefile.lib for the search logic) to change / add
properties as needed.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190117/e5c65329/attachment.sig>
next prev parent reply other threads:[~2019-01-17 22:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 13:34 [U-Boot] [PATCH 1/2] pci: pci_mvebu: Add DM_PCI support and move CONFIG_PCI_MVEBU to defconfig Stefan Roese
2019-01-17 13:34 ` [U-Boot] [PATCH 2/2] arm: mvebu: armada-xp/37x/38x: Enable PCIe DT node Stefan Roese
2019-01-17 19:57 ` Chris Packham
2019-01-17 22:18 ` Tom Rini [this message]
2019-01-18 6:15 ` Stefan Roese
2019-01-18 6:40 ` Chris Packham
2019-01-18 8:53 ` [U-Boot] [PATCH 1/2] pci: pci_mvebu: Add DM_PCI support and move CONFIG_PCI_MVEBU to defconfig Chris Packham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190117221803.GU27429@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox