[U-Boot] [PATCH] Revert "tools: imx8image: set dcd_skip to true"

[U-Boot] [PATCH] Revert "tools: imx8image: set dcd_skip to true"

[Fabio Estevam]

This reverts commit f7e475db4011d18b4ae974154eb022c3af6a4d16.

This commit breaks the boot on imx8qxp evk and it should only
be re-applied after imx8qxp evk is converted to SPL.

Revert it for now, so that imx8qxp evk can be functional.

Reported-by: Breno Lima <breno.lima@nxp.com>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
 tools/imx8image.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/imx8image.c b/tools/imx8image.c
index 435f308b99..d93de733ab 100644
--- a/tools/imx8image.c
+++ b/tools/imx8image.c
@@ -968,7 +968,7 @@ int imx8image_copy_image(int outfd, struct image_tool_params *mparams)
 	fprintf(stdout, "CONTAINER SW VERSION:\t0x%04x\n", sw_version);
 
 	build_container(soc, sector_size, emmc_fastboot,
-			img_sp, true, fuse_version, sw_version, outfd);
+			img_sp, false, fuse_version, sw_version, outfd);
 
 	return 0;
 }
-- 
2.17.1

[U-Boot] [PATCH] Revert "tools: imx8image: set dcd_skip to true"

[Peng Fan]

> -----Original Message-----
> From: Fabio Estevam [mailto:festevam at gmail.com]
> Sent: 2019年1月18日 21:00
> To: sbabic at denx.de
> Cc: Peng Fan <peng.fan@nxp.com>; u-boot at lists.denx.de; Breno Matheus
> Lima <breno.lima@nxp.com>; dl-uboot-imx <uboot-imx@nxp.com>; Fabio
> Estevam <festevam@gmail.com>
> Subject: [PATCH] Revert "tools: imx8image: set dcd_skip to true"
> 
> This reverts commit f7e475db4011d18b4ae974154eb022c3af6a4d16.
> 
> This commit breaks the boot on imx8qxp evk and it should only be re-applied
> after imx8qxp evk is converted to SPL.
> 
> Revert it for now, so that imx8qxp evk can be functional.
> 
> Reported-by: Breno Lima <breno.lima@nxp.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
>  tools/imx8image.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/imx8image.c b/tools/imx8image.c index
> 435f308b99..d93de733ab 100644
> --- a/tools/imx8image.c
> +++ b/tools/imx8image.c
> @@ -968,7 +968,7 @@ int imx8image_copy_image(int outfd, struct
> image_tool_params *mparams)
>  	fprintf(stdout, "CONTAINER SW VERSION:\t0x%04x\n", sw_version);
> 
>  	build_container(soc, sector_size, emmc_fastboot,
> -			img_sp, true, fuse_version, sw_version, outfd);
> +			img_sp, false, fuse_version, sw_version, outfd);

Thanks for spotting this.
Reviewed-by: Peng Fan <peng.fan@nxp.com>

Thanks,
Peng.

> 
>  	return 0;
>  }
> --
> 2.17.1

[U-Boot] [PATCH] Revert "tools: imx8image: set dcd_skip to true"

[Breno Matheus Lima]

Hi Fabio,

Em sex, 18 de jan de 2019 às 11:00, Fabio Estevam <festevam@gmail.com> escreveu:
>
> This reverts commit f7e475db4011d18b4ae974154eb022c3af6a4d16.
>
> This commit breaks the boot on imx8qxp evk and it should only
> be re-applied after imx8qxp evk is converted to SPL.
>
> Revert it for now, so that imx8qxp evk can be functional.
>
> Reported-by: Breno Lima <breno.lima@nxp.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Tested-by: Breno Lima <breno.lima@nxp.com>

Thanks,
Breno Lima

[U-Boot] Revert "tools: imx8image: set dcd_skip to true"

[sbabic at denx.de]

> This reverts commit f7e475db4011d18b4ae974154eb022c3af6a4d16.
> This commit breaks the boot on imx8qxp evk and it should only
> be re-applied after imx8qxp evk is converted to SPL.
> Revert it for now, so that imx8qxp evk can be functional.
> Reported-by: Breno Lima <breno.lima@nxp.com>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> Tested-by: Breno Lima <breno.lima@nxp.com>

Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================