From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 2/9] ARM: rockchip: rk3188: Remove the pinctrl setup and enable uart at SPL
Date: Sat, 19 Jan 2019 00:34:36 +0100 [thread overview]
Message-ID: <20190119003436.1d3ab5de@jawa> (raw)
In-Reply-To: <c301e60d-0740-dc8d-a241-0b1c6a2e86e4@rock-chips.com>
Hi David,
> Hi Heiko,
>
> 在 2019/1/6 上午1:17, Heiko Stuebner 写道:
> >> diff --git a/arch/arm/mach-rockchip/rk3188-board-spl.c
> >> b/arch/arm/mach-rockchip/rk3188-board-spl.c index
> >> 3c6c3d3c09..a5e4d39cb7 100644 ---
> >> a/arch/arm/mach-rockchip/rk3188-board-spl.c +++
> >> b/arch/arm/mach-rockchip/rk3188-board-spl.c @@ -120,7 +120,7 @@
> >> void board_debug_uart_init(void)
> >> void board_init_f(ulong dummy)
> >> {
> >> - struct udevice *pinctrl, *dev;
> >> + struct udevice *dev;
> >> int ret;
> >>
> >> #define EARLY_UART
> >> @@ -134,10 +134,7 @@ void board_init_f(ulong dummy)
> >> * printascii("string");
> >> */
> >> debug_uart_init();
> >> - printch('s');
> >> - printch('p');
> >> - printch('l');
> >> - printch('\n');
> >> + printascii("U-Boot SPL board init");
> > Did you test this change?
> > I remember rk3188 having issues (aka hanging) when trying to print
> > strings through the debug uart and only printch working at all.
> > (Timer issue or so?) ... Not sure if this got fixed in the meantime?
> >
But you are using the debug uart for "production". Please use the
proper driver.
You may either properly setup normal uart or buffer the console output
until the uart is configured by device model (DM).
>
> I don't know there was a issue, but i test it on the Radxa board
> today, it looks okay.
>
> U-Boot SPL board init
> U-Boot SPL 2019.01-rc1-00009-gdd7b9156fe (Jan 14 2019 - 19:53:50
> +0800) Returning to boot ROM...
>
>
> U-Boot 2019.01-rc1-00009-gdd7b9156fe (Jan 14 2019 - 19:53:50 +0800)
>
> Model: Radxa Rock
> DRAM: 2 GiB
> MMC: dwmmc at 10214000: 0
> Loading Environment from MMC... Card did not respond to voltage
> select! *** Warning - No block device, using default environment
>
> In: serial at 20064000
> Out: serial at 20064000
> Err: serial at 20064000
> Model: Radxa Rock
> rockchip_dnl_key_pressed: adc_channel_single_shot fail!
> Net: Net Initialization Skipped
> No ethernet found.
> Hit any key to stop autoboot: 0
> =>
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190119/57047017/attachment.sig>
next prev parent reply other threads:[~2019-01-18 23:34 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 12:50 [U-Boot] [PATCH v2 0/9] Add common pinctrl driver support for rockchip David Wu
2019-01-02 12:50 ` [U-Boot] [PATCH v2 1/9] rockchip: rk3399-evb: defconfig: Enable FDT for new pinctrl driver David Wu
2019-01-10 12:56 ` Simon Glass
2019-01-22 9:11 ` Kever Yang
2019-01-31 10:15 ` [U-Boot] [U-Boot, v2, " Philipp Tomsich
2019-01-31 21:12 ` Philipp Tomsich
2019-01-02 12:50 ` [U-Boot] [PATCH v2 2/9] ARM: rockchip: rk3188: Remove the pinctrl setup and enable uart at SPL David Wu
2019-01-05 17:17 ` Heiko Stuebner
2019-01-05 17:19 ` Heiko Stuebner
2019-01-22 8:57 ` Kever Yang
2019-01-14 12:01 ` David Wu
2019-01-18 23:34 ` Lukasz Majewski [this message]
2019-01-22 9:04 ` [U-Boot] [PATCH v2 2/9] ARM: rockchip: rk3188: Remove the pinctrl setup and enable uart at SPL【请注意，邮件由u-boot-bounces@lists.denx.de代发】 Kever Yang
2019-01-22 10:27 ` Lukasz Majewski
2019-01-22 9:10 ` [U-Boot] [PATCH v2 2/9] ARM: rockchip: rk3188: Remove the pinctrl setup and enable uart at SPL David Wu
2019-01-22 9:11 ` Kever Yang
2019-01-31 10:15 ` [U-Boot] [U-Boot, v2, " Philipp Tomsich
2019-01-31 21:12 ` Philipp Tomsich
2019-01-02 12:50 ` [U-Boot] [PATCH v2 3/9] ARM: rockchip: Kconfig: Remove the SPL_PINCTRL for rk3188 David Wu
2019-01-22 9:12 ` Kever Yang
2019-01-31 10:15 ` [U-Boot] [U-Boot, v2, " Philipp Tomsich
2019-01-31 21:12 ` Philipp Tomsich
2019-01-02 12:51 ` [U-Boot] [PATCH v2 4/9] ARM: rockchip: Remove the pinctrl request at rk3288-board-spl David Wu
2019-01-22 9:12 ` Kever Yang
2019-01-31 10:15 ` [U-Boot] [U-Boot, v2, " Philipp Tomsich
2019-01-31 21:12 ` Philipp Tomsich
2019-01-02 13:00 ` [U-Boot] [PATCH v2 5/9] rk3288: chrome: defconfig: Enable FDT for new pinctrl driver David Wu
2019-01-31 10:15 ` [U-Boot] [U-Boot, v2, " Philipp Tomsich
2019-01-31 21:12 ` Philipp Tomsich
2019-01-02 13:00 ` [U-Boot] [PATCH v2 6/9] pinctrl: rockchip: Add common rockchip " David Wu
2019-01-05 17:27 ` Heiko Stuebner
2019-01-06 18:57 ` Philipp Tomsich
2019-01-06 20:49 ` Heiko Stuebner
2019-01-22 9:15 ` Kever Yang
2019-01-31 10:15 ` [U-Boot] [U-Boot, v2, " Philipp Tomsich
2019-01-31 21:12 ` Philipp Tomsich
2019-01-02 13:01 ` [U-Boot] [PATCH v2 7/9] rockchip: defconfig: Clean the unused pinctrl config David Wu
2019-01-22 9:16 ` Kever Yang
2019-01-31 10:15 ` [U-Boot] [U-Boot, v2, " Philipp Tomsich
2019-01-31 21:12 ` Philipp Tomsich
2019-02-05 10:49 ` Emmanuel Vadot
2019-02-05 10:51 ` Philipp Tomsich
2019-01-02 13:02 ` [U-Boot] [PATCH v2 8/9] pinctrl: rockchip: Clean the unused rockchip pinctrl drivers David Wu
2019-01-10 12:56 ` Simon Glass
2019-01-22 9:16 ` Kever Yang
2019-01-31 10:15 ` [U-Boot] [U-Boot, v2, " Philipp Tomsich
2019-01-31 21:12 ` Philipp Tomsich
2019-01-02 13:02 ` [U-Boot] [PATCH v2 9/9] ARM: dts: rk322x: Correct the uart2 default pin configuration David Wu
2019-01-22 9:16 ` Kever Yang
2019-01-31 10:15 ` [U-Boot] [U-Boot, v2, " Philipp Tomsich
2019-01-31 21:12 ` Philipp Tomsich
2019-01-21 18:50 ` [U-Boot] [PATCH v2 0/9] Add common pinctrl driver support for rockchip Simon Glass
2019-01-24 2:26 ` David Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190119003436.1d3ab5de@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox