From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] cmd: mtd: fix compilation warning for help when SYS_LONGHELP=n
Date: Fri, 18 Jan 2019 21:53:49 -0500 [thread overview]
Message-ID: <20190119025349.GP27429@bill-the-cat> (raw)
In-Reply-To: <20190117091847.27646-1-quentin.schulz@bootlin.com>
On Thu, Jan 17, 2019 at 10:18:47AM +0100, Quentin Schulz wrote:
> cmd/mtd.c:447:13: warning: ‘mtd_help_text’ defined but not used [-Wunused-variable]
> static char mtd_help_text[] =
> ^~~~~~~~~~~~~
>
> When SYS_LONGHELP is not defined. After looking at how other commands
> work, we should surround the whole help text (even its declaration) with
> an #ifdef CONFIG_SYS_LONGHELP, since it's compiled out when calling
> _CMD_HELP[1] on the help text variable argument to U_BOOT_CMD.
>
> [1] https://elixir.bootlin.com/u-boot/latest/source/include/command.h#L181
>
> Signed-off-by: Quentin Schulz <quentin.schulz@bootlin.com>
> Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190118/4755b2d4/attachment.sig>
prev parent reply other threads:[~2019-01-19 2:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 9:18 [U-Boot] [PATCH] cmd: mtd: fix compilation warning for help when SYS_LONGHELP=n Quentin Schulz
2019-01-17 9:22 ` Miquel Raynal
2019-01-19 2:53 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190119025349.GP27429@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox