From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rask Ingemann Lambertsen Date: Sat, 19 Jan 2019 16:21:07 +0100 Subject: [U-Boot] [PATCH 1/9] dm: allow 4GB of DRAM on 32bit systems In-Reply-To: References: <1532613591-8444-1-git-send-email-philipp.tomsich@theobroma-systems.com> <1532613591-8444-2-git-send-email-philipp.tomsich@theobroma-systems.com> <21E61B71-9134-4722-B086-FDA23EA894F9@theobroma-systems.com> <968d7702-4675-d442-40db-d04ad1c751c2@suse.de> <8736ur7uo4.fsf@aikidev.net> <6FA17B64-ECEE-48B9-B756-ECEF9C07E66A@suse.de> Message-ID: <20190119152107.GB2281@localhost> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 03-09-2018 at 19:59 +0530, Lokesh Vutla wrote: > > On Sunday 02 September 2018 11:19 PM, Alexander Graf wrote: > > > >> Am 02.09.2018 um 18:04 schrieb Vagrant Cascadian : > >> > >>> With LPAE available in all modern ARM cores, shouldn't phys_addr_t just > >>> be u64? And then we'd probably want to use that throughout the code, right? > >> > >> Quite a few currently supported boards do not support LPAE, e.g. imx6. > > > > What I'm trying to say is that we probably want to make phys_addr_t be u64 when CONFIG_LPAE is set. > > That's right. Enabling PHYS_64BIT should be sufficient. Based on this > phys_addr_t should be set to u32 or u64. arm already does that[1]. That will cause warnings from at least two sunxi drivers. I forgot which one the other was, but sunxi_mmc is one of them: $ git grep -F -e '(u32 *)' drivers/mmc/sunxi_mmc.c drivers/mmc/sunxi_mmc.c: ccu_reg = (u32 *)ofnode_get_addr(args.node); drivers/mmc/sunxi_mmc.c: mmc_config_clk = (u32 *)ofnode_get_addr(args.node); becase ofnode_get_addr() is declared like so: include/dm/ofnode.h:phys_addr_t ofnode_get_addr(ofnode node); -- Best regards, Rask Ingemann Lambertsen