From: Marek Behun <marek.behun@nic.cz>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/6] watchdog: bcm6345: switch to raw I/O functions
Date: Tue, 22 Jan 2019 00:37:53 +0100 [thread overview]
Message-ID: <20190122003753.2536e120@nic.cz> (raw)
In-Reply-To: <1548090453-8913-1-git-send-email-philippe.reynes@softathome.com>
Hi,
You have to add some commit message, even if it is only one line,
describing why are you doing these changes.
Marek
On Mon, 21 Jan 2019 18:07:28 +0100
Philippe Reynes <philippe.reynes@softathome.com> wrote:
> Signed-off-by: Philippe Reynes <philippe.reynes@softathome.com>
> ---
> drivers/watchdog/bcm6345_wdt.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/watchdog/bcm6345_wdt.c
> b/drivers/watchdog/bcm6345_wdt.c index e1bd73d..44f5662 100644
> --- a/drivers/watchdog/bcm6345_wdt.c
> +++ b/drivers/watchdog/bcm6345_wdt.c
> @@ -32,8 +32,8 @@ static int bcm6345_wdt_reset(struct udevice *dev)
> {
> struct bcm6345_wdt_priv *priv = dev_get_priv(dev);
>
> - writel_be(WDT_CTL_START1_MASK, priv->regs + WDT_CTL_REG);
> - writel_be(WDT_CTL_START2_MASK, priv->regs + WDT_CTL_REG);
> + writel(WDT_CTL_START1_MASK, priv->regs + WDT_CTL_REG);
> + writel(WDT_CTL_START2_MASK, priv->regs + WDT_CTL_REG);
>
> return 0;
> }
> @@ -50,7 +50,7 @@ static int bcm6345_wdt_start(struct udevice *dev,
> u64 timeout, ulong flags) timeout = WDT_VAL_MAX;
> }
>
> - writel_be(timeout, priv->regs + WDT_VAL_REG);
> + writel(timeout, priv->regs + WDT_VAL_REG);
>
> return bcm6345_wdt_reset(dev);
> }
> @@ -64,8 +64,8 @@ static int bcm6345_wdt_stop(struct udevice *dev)
> {
> struct bcm6345_wdt_priv *priv = dev_get_priv(dev);
>
> - writel_be(WDT_CTL_STOP1_MASK, priv->regs + WDT_CTL_REG);
> - writel_be(WDT_CTL_STOP2_MASK, priv->regs + WDT_CTL_REG);
> + writel(WDT_CTL_STOP1_MASK, priv->regs + WDT_CTL_REG);
> + writel(WDT_CTL_STOP2_MASK, priv->regs + WDT_CTL_REG);
>
> return 0;
> }
prev parent reply other threads:[~2019-01-21 23:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-21 17:07 [U-Boot] [PATCH 1/6] watchdog: bcm6345: switch to raw I/O functions Philippe Reynes
2019-01-21 17:07 ` [U-Boot] [PATCH 2/6] watchdog: bcm6345: allow to use this driver on arm Philippe Reynes
2019-01-21 17:07 ` [U-Boot] [PATCH 3/6] dt: bcm6838: add watchdog Philippe Reynes
2019-01-21 17:07 ` [U-Boot] [PATCH 4/6] dt: bcm6858: " Philippe Reynes
2019-01-21 17:07 ` [U-Boot] [PATCH 5/6] bcm968380gerg_ram_defconfig: enable watchdog and reboot with watchdog Philippe Reynes
2019-01-21 17:07 ` [U-Boot] [PATCH 6/6] bcm968580_ram_defconfig: " Philippe Reynes
2019-01-21 23:37 ` Marek Behun [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190122003753.2536e120@nic.cz \
--to=marek.behun@nic.cz \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox