From mboxrd@z Thu Jan 1 00:00:00 1970 From: AKASHI Takahiro Date: Wed, 23 Jan 2019 13:56:18 +0900 Subject: [U-Boot] [PATCH v5 2/7] cmd: efidebug: add devices command In-Reply-To: References: <20190121074923.29959-1-takahiro.akashi@linaro.org> <20190121074923.29959-3-takahiro.akashi@linaro.org> <24b86993-b5c6-991f-fd69-eb5aaa42a0b3@suse.de> <20190122013813.GA20286@linaro.org> Message-ID: <20190123045617.GG20286@linaro.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, Jan 22, 2019 at 10:19:35AM +0100, Alexander Graf wrote: > > > On 22.01.19 02:38, AKASHI Takahiro wrote: > > Alex, > > > > On Mon, Jan 21, 2019 at 02:34:43PM +0100, Alexander Graf wrote: > >> On 01/21/2019 08:49 AM, AKASHI Takahiro wrote: > >>> "devices" command prints all the uefi variables on the system. > >>> > >>> => efi devices > >>> Scanning disk ahci_scsi.id0lun0... > >>> Scanning disk ahci_scsi.id1lun0... > >>> Found 4 disks > >>> D > >>> e > >>> v Device Path > >> > >> Why the weird formatting of "Dev"? > > > > Good question :) > > The format mimics a EDK2's shell. > > The purpose is that we will be able to add some *narrow* data fields > > later without spilling out a line length. > > > > But I admit that we don't have to do so because we have an enough width, > > 16 digits, for ID (or address of efi object in this case). > > > > === From EDK2 UEFI Shell output === > > Shell> drivers > > T D > > D Y C I > > e P F A > > V VERSION E G G #D #C DRIVER NAME IMAGE NAME > > == ======== = = = == == =================================== ========== > > 6E 0000000A D - - 1 - Platform Console Management Driver ConPlatformDxe > > Ah, yes, in this output it makes sense. We don't have the table header > size problem though, so let's please not pull that ugly header in :). Okay. I will also modify the code so that this field (address of efi_handle_t) can be 32-bit or 64-bit wide. -Takahiro Akashi > > Alex