From mboxrd@z Thu Jan 1 00:00:00 1970 From: AKASHI Takahiro Date: Wed, 23 Jan 2019 14:11:33 +0900 Subject: [U-Boot] [PATCH v3 0/5] subject: efi_loader: add HII database protocol In-Reply-To: <9e56d840-3a9d-b0ce-6276-1e652eb540c2@gmx.de> References: <20190121031301.1808-1-takahiro.akashi@linaro.org> <77c8ee35-8b56-17a9-22d0-d0c32e848be3@suse.de> <9e56d840-3a9d-b0ce-6276-1e652eb540c2@gmx.de> Message-ID: <20190123051132.GH20286@linaro.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Heinrich, On Tue, Jan 22, 2019 at 10:13:52PM +0100, Heinrich Schuchardt wrote: > On 1/22/19 10:48 AM, Alexander Graf wrote: > > > > > > On 21.01.19 04:12, AKASHI Takahiro wrote: > >> HII database protocol is the last missing (major?) piece of code so that > >> we can run unmodified EDKII's shell and UEFI SCT on EFI-enabled u-boot. > >> > >> The original code was initially written by Leif and Rob a year ago[1], > >> and now I'm reworking it. The implementation has not been much > >> enhanced from the original, but I tried to give it clearer implementation > >> to be able to add more functionality easily later on. > >> I also addressed the comments by Alex[2] and added a self test on > >> request of Heinrich. > >> > >> HII configuration routing protocol and access protocol have only > >> a skeleton and should be implemented when we need to have *drivers* > >> that require configuration mechanism. > > > > Reviewed-by: Alexander Graf > > > > But I'll wait for Heinrich's ok as well :) > > > > > > Alex > > > I have seen that Takahiro has integrated my recent suggestions. > > Currently I am still trying to understand what is wrong with > GetNextVariableName(). Thank you for finding and investigating this issue. I almost all of my time test my patches on arm64 primarily :) -Takahiro Akashi > So let's go with your review. > > Best regards > > Heinrich