From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/6] firmware: ti_sci: Add support for NAVSS resource management
Date: Wed, 23 Jan 2019 08:56:47 -0500 [thread overview]
Message-ID: <20190123135647.GF28173@bill-the-cat> (raw)
In-Reply-To: <78b04225-522c-2970-b2a9-58ed1e7bb68a@ti.com>
On Wed, Jan 23, 2019 at 07:19:30PM +0530, Vignesh R wrote:
>
>
> On 23/01/19 12:26 AM, Tom Rini wrote:
> > On Tue, Jan 22, 2019 at 08:33:54PM +0530, Vignesh R wrote:
> >
> >> From: Grygorii Strashko <grygorii.strashko@ti.com>
> >>
> >> Texas Instruments' System Control Interface (TI-SCI) Message Protocol
> >> abstracts management of NAVSS resources, like PSI-L pairing and
> >> unpairing, UDMAP tx/rx/flow configuration and Rings.
> >>
> >> This patch adds support for requesting and configuring such resources
> >> from TI-SCI firmware.
> >>
> >> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> >> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> >
> > Reviewed-by: Tom Rini <trini@konsulko.com>
> >
> > But:
> >> +/**
> >> + * Configures a Navigator Subsystem UDMAP transmit channel
> >> + *
> >> + * Configures a Navigator Subsystem UDMAP transmit channel registers.
> >> + * See @ti_sci_msg_rm_udmap_tx_ch_cfg_req
> >> + */
> >> +struct ti_sci_msg_rm_udmap_tx_ch_cfg {
> >> + u32 valid_params;
> >> +#define TI_SCI_MSG_VALUE_RM_UDMAP_CH_TX_FILT_EINFO_VALID BIT(9)
> >> +#define TI_SCI_MSG_VALUE_RM_UDMAP_CH_TX_FILT_PSWORDS_VALID BIT(10)
> >> +#define TI_SCI_MSG_VALUE_RM_UDMAP_CH_TX_SUPR_TDPKT_VALID BIT(11)
> >> +#define TI_SCI_MSG_VALUE_RM_UDMAP_CH_TX_CREDIT_COUNT_VALID BIT(12)
> >> +#define TI_SCI_MSG_VALUE_RM_UDMAP_CH_TX_FDEPTH_VALID BIT(13)
> >
> > This and similar instances are some pretty odd style. Rework to be the
> > defines then the struct?
> >
>
> Its pretty common style (at least in kernel code) to #define constants
> just below a struct member to indicate that these flags apply only to
> that member. I can rework if you feel otherwise.
Really? Alright, leave it I guess then, thanks.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190123/2117619c/attachment.sig>
next prev parent reply other threads:[~2019-01-23 13:56 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-22 15:03 [U-Boot] [PATCH 0/6] AM65x: Add DMA support Vignesh R
2019-01-22 15:03 ` [U-Boot] [PATCH 1/6] firmware: ti_sci: Add support for NAVSS resource management Vignesh R
2019-01-22 18:56 ` Tom Rini
2019-01-23 13:49 ` Vignesh R
2019-01-23 13:56 ` Tom Rini [this message]
2019-01-22 15:03 ` [U-Boot] [PATCH 2/6] soc: ti: k3: add navss ringacc driver Vignesh R
2019-01-22 18:56 ` Tom Rini
2019-01-23 13:50 ` Vignesh R
2019-01-22 15:03 ` [U-Boot] [PATCH 3/6] soc: ti: k3: add CPPI5 description and helpers Vignesh R
2019-01-22 18:56 ` Tom Rini
2019-01-22 15:03 ` [U-Boot] [PATCH 4/6] dma: ti: add driver to K3 UDMA Vignesh R
2019-01-22 18:56 ` Tom Rini
2019-01-23 10:35 ` Peter Ujfalusi
2019-01-23 13:43 ` Vignesh R
2019-01-23 13:56 ` Tom Rini
2019-01-25 14:23 ` Vignesh R
2019-01-23 13:52 ` Tom Rini
2019-01-22 15:03 ` [U-Boot] [PATCH 5/6] arm64: dts: ti: k3-am65: add mcu navss nodes Vignesh R
2019-01-22 18:56 ` Tom Rini
2019-01-22 15:03 ` [U-Boot] [PATCH 6/6] configs: am65x_evm_a53: Enable DMA related configs Vignesh R
2019-01-22 18:56 ` Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123135647.GF28173@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox