[U-Boot] [PATCH v2 2/3] efi_loader: enumerate disk devices every time

Simon Glass
2019-01-12T21:32:04Z

Hi Alex,

On Fri, 11 Jan 2019 at 00:57, Alexander Graf <agraf@suse.de> wrote:
>
>
>
> On 11.01.19 05:29, AKASHI Takahiro wrote:
> > Alex, Heinrich and Simon,
> >
> > Thank you for your comments, they are all valuable but also make me
> > confused as different people have different requirements :)
> > I'm not sure that all of us share the same *ultimate* goal here.
>
> The shared ultimate goal is to "merge" (as Simon put it) dm and efi objects.
>
> But we have this annoying interim state where we would lose a few boards
> because they haven't been converted to DM. That's what keeps us from it.

I don't think that is true anymore. The deadline for patches is
effectively 28th January.

>
> I think what this discussion boils down to is that someone needs to
> start prototyping the DM/EFI integration. Start off with a simple
> subsystem, like BLK. Then provide a DM path and have a non-DM fallback
> still in its own source file that also provides EFI BLK devices.
> Eventually we just remove the latter.

No fallback, please. As above, it is time to remove code that does not
use CONFIG_BLK.

>
> That way we can then work on getting hotplug working in the DM path,
> which is the one we want anyway. For non-DM, you simply miss out on that
> amazing new feature, but we don't regress users.

Of which there will not be any as of 2019.04. I'm sorry to belabour
this point, but I feel quite strongly that we should not be adding new
code to old frameworks. We should instead be migrating away from them
and deleting them.

Regards,
Simon