From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] configs: Enable CONFIG_BLK in a few TI boards
Date: Fri, 25 Jan 2019 09:54:37 -0500 [thread overview]
Message-ID: <20190125145437.GP6906@bill-the-cat> (raw)
In-Reply-To: <d78c41dd-3093-9fba-17ad-571cbb59f0e1@ti.com>
On Fri, Jan 25, 2019 at 03:40:35PM +0100, Jean-Jacques Hiblot wrote:
>
> On 15/01/2019 15:28, Tom Rini wrote:
> >On Tue, Jan 08, 2019 at 06:16:31PM +0530, Faiz Abbas wrote:
> >
> >>With DM conversion completed, enable CONFIG_BLK for a
> >>few pending TI boards.
> >>
> >>Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
> >>Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
> >>---
> >> configs/am335x_boneblack_vboot_defconfig | 1 -
> >> configs/am335x_evm_defconfig | 1 -
> >> configs/am335x_hs_evm_defconfig | 1 -
> >> configs/am335x_hs_evm_uart_defconfig | 1 -
> >> configs/am43xx_evm_defconfig | 1 -
> >> configs/am43xx_evm_qspiboot_defconfig | 1 -
> >> configs/am43xx_evm_rtconly_defconfig | 1 -
> >> configs/am43xx_evm_usbhost_boot_defconfig | 1 -
> >> configs/am43xx_hs_evm_defconfig | 1 -
> >> configs/am57xx_evm_defconfig | 1 -
> >> configs/am57xx_hs_evm_defconfig | 1 -
> >> configs/k2g_evm_defconfig | 1 -
> >> configs/k2g_hs_evm_defconfig | 1 -
> >> 13 files changed, 13 deletions(-)
> >So, a problem with this patch is that we can't only enable CONFIG_BLK in
> >all cases, we also need to make sure that if we have MMC we have DM_MMC
> >and if we have USB we have DM_USB. This latter case is what tripped me
> >up as am43xx_evm_usbhost_boot_defconfig will have a warning with this
> >patch applied as SPL_USB_SUPPORT really requires CONFIG_USB_STORAGE
> >support and that in turn depends on either (BLK==n && DM_USB==n) or
> >(BLK==y && DM_USB==y).
>
> Maybe we should break this down.
>
> 1) k2g and am57: they already have the right options enabled.
>
> 2) am335x: the options are also present, although some are disabled in SPL
>
> 3) am43x: some configs need to be converted to DM_USB and DM_MMC first.
Yes, submitting this as a 3 or 4 part change that goes per-SoC would be
good, and clear that you're also changing a bit more on am43xx. Thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190125/33d61547/attachment.sig>
next prev parent reply other threads:[~2019-01-25 14:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-08 12:46 [U-Boot] [PATCH] configs: Enable CONFIG_BLK in a few TI boards Faiz Abbas
2019-01-08 13:30 ` Lokesh Vutla
2019-01-15 14:28 ` [U-Boot] " Tom Rini
2019-01-25 14:40 ` Jean-Jacques Hiblot
2019-01-25 14:54 ` Tom Rini [this message]
2019-01-30 11:55 ` Faiz Abbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190125145437.GP6906@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox