From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anatolij Gustschin Date: Mon, 28 Jan 2019 20:56:11 +0100 Subject: [U-Boot] [PATCH u-boot 04/11] video: Add Meson Video Processing Unit Driver In-Reply-To: <20190115161759.1657-5-narmstrong@baylibre.com> References: <20190115161759.1657-1-narmstrong@baylibre.com> <20190115161759.1657-5-narmstrong@baylibre.com> Message-ID: <20190128205611.46598f8a@crub> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Tue, 15 Jan 2019 17:17:52 +0100 Neil Armstrong narmstrong at baylibre.com wrote: > This adds video output support for Amlogic GXBB/GXL/GXM chips. > The supported ports are CVBS and HDMI (based on DW_HDMI). > > When using HDMI, only DMT modes are supported. > > There is support for simple-framebuffer (CONFIG_VIDEO_DT_SIMPLEFB) > > Signed-off-by: Neil Armstrong > Signed-off-by: Jorge Ramire-Ortiz > Signed-off-by: Maxime Jourdan Reviewed-by: Anatolij Gustschin Please see minor comment below. > diff --git a/drivers/video/meson/meson_canvas.c b/drivers/video/meson/meson_canvas.c ... > +/* DMC Registers */ > +#define DMC_CAV_LUT_DATAL 0x48 /* 0x12 offset in data sheet */ > +#define CANVAS_WIDTH_LBIT 29 > +#define CANVAS_WIDTH_LWID 3 > +#define DMC_CAV_LUT_DATAH 0x4c /* 0x13 offset in data sheet */ > +#define CANVAS_WIDTH_HBIT 0 > +#define CANVAS_HEIGHT_BIT 9 > +#define CANVAS_BLKMODE_BIT 24 > +#define DMC_CAV_LUT_ADDR 0x50 /* 0x14 offset in data sheet */ > +#define CANVAS_LUT_WR_EN (0x2 << 8) > +#define CANVAS_LUT_RD_EN (0x1 << 8) Some define values are not aligned by tab here. -- Anatolij