* [U-Boot] [PATCH] imx: video: Fix return value issue
@ 2019-01-04 9:11 Ye Li
2019-01-05 9:35 ` Peng Fan
2019-01-28 20:15 ` Anatolij Gustschin
0 siblings, 2 replies; 3+ messages in thread
From: Ye Li @ 2019-01-04 9:11 UTC (permalink / raw)
To: u-boot
When framebuffer driver init is failed, we should return the err value not 0.
So the video init can exit immediately.
Signed-off-by: Ye Li <ye.li@nxp.com>
---
arch/arm/mach-imx/video.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-imx/video.c b/arch/arm/mach-imx/video.c
index b40ce53..953fe53 100644
--- a/arch/arm/mach-imx/video.c
+++ b/arch/arm/mach-imx/video.c
@@ -7,7 +7,7 @@
int board_video_skip(void)
{
int i;
- int ret;
+ int ret = 0;
char const *panel = env_get("panel");
if (!panel) {
@@ -50,7 +50,7 @@ int board_video_skip(void)
return -EINVAL;
}
- return 0;
+ return ret;
}
#ifdef CONFIG_IMX_HDMI
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] imx: video: Fix return value issue
2019-01-04 9:11 [U-Boot] [PATCH] imx: video: Fix return value issue Ye Li
@ 2019-01-05 9:35 ` Peng Fan
2019-01-28 20:15 ` Anatolij Gustschin
1 sibling, 0 replies; 3+ messages in thread
From: Peng Fan @ 2019-01-05 9:35 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Ye Li
> Sent: 2019年1月4日 17:11
> To: sbabic at denx.de; u-boot at lists.denx.de
> Cc: Fabio Estevam <fabio.estevam@nxp.com>; Peng Fan
> <peng.fan@nxp.com>; dl-uboot-imx <uboot-imx@nxp.com>
> Subject: [PATCH] imx: video: Fix return value issue
>
> When framebuffer driver init is failed, we should return the err value not 0.
> So the video init can exit immediately.
>
> Signed-off-by: Ye Li <ye.li@nxp.com>
> ---
> arch/arm/mach-imx/video.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-imx/video.c b/arch/arm/mach-imx/video.c index
> b40ce53..953fe53 100644
> --- a/arch/arm/mach-imx/video.c
> +++ b/arch/arm/mach-imx/video.c
> @@ -7,7 +7,7 @@
> int board_video_skip(void)
> {
> int i;
> - int ret;
> + int ret = 0;
> char const *panel = env_get("panel");
>
> if (!panel) {
> @@ -50,7 +50,7 @@ int board_video_skip(void)
> return -EINVAL;
> }
>
> - return 0;
> + return ret;
> }
>
> #ifdef CONFIG_IMX_HDMI
Reviewed-by: Peng Fan <peng.fan@nxp.com>
> --
> 2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* [U-Boot] [PATCH] imx: video: Fix return value issue
2019-01-04 9:11 [U-Boot] [PATCH] imx: video: Fix return value issue Ye Li
2019-01-05 9:35 ` Peng Fan
@ 2019-01-28 20:15 ` Anatolij Gustschin
1 sibling, 0 replies; 3+ messages in thread
From: Anatolij Gustschin @ 2019-01-28 20:15 UTC (permalink / raw)
To: u-boot
On Fri, 4 Jan 2019 09:11:05 +0000
Ye Li ye.li at nxp.com wrote:
> When framebuffer driver init is failed, we should return the err value not 0.
> So the video init can exit immediately.
>
> Signed-off-by: Ye Li <ye.li@nxp.com>
> ---
> arch/arm/mach-imx/video.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Applied to u-boot-video/master, thanks!
--
Anatolij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-28 20:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-04 9:11 [U-Boot] [PATCH] imx: video: Fix return value issue Ye Li
2019-01-05 9:35 ` Peng Fan
2019-01-28 20:15 ` Anatolij Gustschin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox