public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v1 0/3] Add support for symlink creation in EXT4
Date: Tue, 29 Jan 2019 18:26:52 -0500	[thread overview]
Message-ID: <20190129232652.GR30838@bill-the-cat> (raw)
In-Reply-To: <20190130002429.39e60861@jawa>

On Wed, Jan 30, 2019 at 12:24:29AM +0100, Lukasz Majewski wrote:
> On Tue, 29 Jan 2019 14:40:08 +0100
> Jean-Jacques Hiblot <jjhiblot@ti.com> wrote:
> 
> > This series adds support for the creation of symbolic links on ext4
> > file-systems.
> > The motivation behind this work is to have the ability to "do" the job
> > of update-alternatives in u-boot.
> > Firmware on TI's platform are usually managed with
> > update-alternatives and are thus targeted by a symbolic link. In some
> > situations we need the ability to select an alternate firmware before
> > the linux kernel is started so that when a early driver needing the
> > firmware comes up, it can be fed the firmware of our choice.
> > 
> > Tested on a am57xx_evm, using a EXT4 partition on external SDcard.
> > The filesystem can be checked later with: fsck.ext4 -f <dev>
> > 
> > usage example:
> > => ln mmc 0:2 zImage /boot/the_linux_kernel 
> 
> Could you also add a test for symlink to sandbox? This is a high level
> code (FS ext4), so it can be nice tested there.
>  
> > 
> > 
> > Jean-Jacques Hiblot (3):
> >   fs: ext4: constify the buffer passed to write functions
> >   fs: ext4: Add support for the creation of symbolic links
> >   fs: Add a new command to create symbolic links
> > 
> >  cmd/fs.c              | 14 ++++++++++++
> >  fs/ext4/ext4_common.c |  6 ++---
> >  fs/ext4/ext4_common.h |  2 +-
> >  fs/ext4/ext4_write.c  | 51
> > ++++++++++++++++++++++++++++++++----------- fs/fs.c               |
> > 44 +++++++++++++++++++++++++++++++++++++ include/ext4fs.h      |  5
> > +++-- include/fs.h          |  2 ++
> >  7 files changed, 105 insertions(+), 19 deletions(-)

Yes, now that we have tests under pytest, we need to drop something for
this under test/py/tests/test_fs/ and my first thought is in a new
test_symlink.py file so that someday when we get more than just FAT/EXTn
tests the next FS that supports symlinks gets the tests for free if/when
it supports symlinks.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190129/0dba0276/attachment.sig>

      reply	other threads:[~2019-01-29 23:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-29 13:40 [U-Boot] [PATCH v1 0/3] Add support for symlink creation in EXT4 Jean-Jacques Hiblot
2019-01-29 13:40 ` [U-Boot] [PATCH v1 1/3] fs: ext4: constify the buffer passed to write functions Jean-Jacques Hiblot
2019-01-29 13:40 ` [U-Boot] [PATCH v1 2/3] fs: ext4: Add support for the creation of symbolic links Jean-Jacques Hiblot
2019-01-29 13:40 ` [U-Boot] [PATCH v1 3/3] fs: Add a new command to create " Jean-Jacques Hiblot
2019-01-29 23:24 ` [U-Boot] [PATCH v1 0/3] Add support for symlink creation in EXT4 Lukasz Majewski
2019-01-29 23:26   ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190129232652.GR30838@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox