public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 16/20] imx8m: fix sd to mmc1 and emmc to mmc2 for i.MX8MM
Date: Tue, 29 Jan 2019 23:57:59 +0100	[thread overview]
Message-ID: <20190129235759.3b561dfb@jawa> (raw)
In-Reply-To: <20190128094807.26532-17-peng.fan@nxp.com>

Hi Peng,

> Since the SD is usdhc2 and eMMC is usdhc3,

Is this true on all IMX8M boards? Or is it only on the development kit
you do have?

My point is that this shall be setup by DTS aliases or maybe by Kconfig
option.

> this cause mapping problem
> for spl_boot_device. So far hard coded them to correct MMC index, so
> that SD and eMMC boot can work.
> 
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm/mach-imx/spl.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/arch/arm/mach-imx/spl.c b/arch/arm/mach-imx/spl.c
> index ebd8ff9290..0048832be8 100644
> --- a/arch/arm/mach-imx/spl.c
> +++ b/arch/arm/mach-imx/spl.c
> @@ -147,9 +147,18 @@ u32 spl_boot_device(void)
>  	case SD1_BOOT:
>  	case MMC1_BOOT:
>  		return BOOT_DEVICE_MMC1;
> +#if defined(CONFIG_IMX8MM)
> +	case SD2_BOOT:
> +	case MMC2_BOOT:
> +		return BOOT_DEVICE_MMC1;
> +	case SD3_BOOT:
> +	case MMC3_BOOT:
> +		return BOOT_DEVICE_MMC2;
> +#else
>  	case SD2_BOOT:
>  	case MMC2_BOOT:
>  		return BOOT_DEVICE_MMC2;
> +#endif
>  #endif
>  	case NAND_BOOT:
>  		return BOOT_DEVICE_NAND;




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190129/06f45f3a/attachment.sig>

  reply	other threads:[~2019-01-29 22:57 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-28  9:39 [U-Boot] [PATCH 00/20] imx: add i.MX8MM support Peng Fan
2019-01-28  9:39 ` [U-Boot] [PATCH 01/20] imx: add IMX8MM kconfig entry Peng Fan
2019-01-28  9:39 ` [U-Boot] [PATCH 02/20] imx8: cpu: restrict checking ROM passover info for revA Peng Fan
2019-01-28  9:39 ` [U-Boot] [PATCH 03/20] imx: imx8mm: add clock bindings header Peng Fan
2019-01-28  9:39 ` [U-Boot] [PATCH 04/20] imx: add pin binding header for i.MX8MM Peng Fan
2019-01-28  9:39 ` [U-Boot] [PATCH 05/20] imx: add i.MX8MM cpu type Peng Fan
2019-01-28  9:39 ` [U-Boot] [PATCH 06/20] imx8m: update imx-regs for i.MX8MM Peng Fan
2019-01-28  9:39 ` [U-Boot] [PATCH 07/20] imx: add get_cpu_rev support " Peng Fan
2019-01-28  9:39 ` [U-Boot] [PATCH 08/20] imx8m: rename clock to clock_imx8mq Peng Fan
2019-01-28  9:39 ` [U-Boot] [PATCH 09/20] imx8m: restructure clock.h Peng Fan
2019-01-28  9:39 ` [U-Boot] [PATCH 10/20] imx8m: add clk support for i.MX8MM Peng Fan
2019-01-29 22:54   ` Lukasz Majewski
2019-01-30  5:46     ` Peng Fan
2019-01-30  6:46       ` Lukasz Majewski
2019-01-30  6:56         ` Peng Fan
2019-01-30  8:22           ` Lukasz Majewski
2019-01-28  9:39 ` [U-Boot] [PATCH 11/20] imx8m: add pin header " Peng Fan
2019-01-28  9:39 ` [U-Boot] [PATCH 12/20] imx: add i.MX8MM PE property Peng Fan
2019-01-28  9:39 ` [U-Boot] [PATCH 13/20] imx8m: Fix MMU table issue for OPTEE memory Peng Fan
2019-01-28  9:39 ` [U-Boot] [PATCH 14/20] imx8m: set BYPASS ID SWAP to avoid AXI bus errors Peng Fan
2019-01-28  9:40 ` [U-Boot] [PATCH 15/20] imx8m: Configure trustzone region 0 for non-secure access Peng Fan
2019-01-28  9:40 ` [U-Boot] [PATCH 16/20] imx8m: fix sd to mmc1 and emmc to mmc2 for i.MX8MM Peng Fan
2019-01-29 22:57   ` Lukasz Majewski [this message]
2019-01-29 23:01     ` Fabio Estevam
2019-01-30  5:47     ` Peng Fan
2019-01-30  6:50       ` Lukasz Majewski
2019-01-30  6:51         ` Peng Fan
2019-01-30  8:19           ` Lukasz Majewski
2019-01-28  9:40 ` [U-Boot] [PATCH 17/20] imx8m: soc: enable SCTR clock before timer init Peng Fan
2019-01-28  9:40 ` [U-Boot] [PATCH 18/20] serial: Kconfig: make MXC_UART usable for MX7 and IMX8M Peng Fan
2019-01-28  9:43 ` [U-Boot] [PATCH 19/20] pinctrl: add imx8m driver Peng Fan
2019-01-28  9:43 ` [U-Boot] [PATCH 20/20] imx: add i.MX8MM EVK board support Peng Fan
2019-01-29 23:18   ` Lukasz Majewski
2019-01-30  5:49     ` Peng Fan
2019-01-30  6:53       ` Lukasz Majewski
2019-01-30  7:07         ` Peng Fan
2019-01-30  8:37           ` Lukasz Majewski
2019-01-30  8:50             ` Peng Fan
2019-01-30 10:10               ` Lukasz Majewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190129235759.3b561dfb@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox