[U-Boot] [PATCH v4 00/20] mx6sabre: Add DM and SPL FIT support

Abel Vesa
2019-02-04T09:55:36Z

On 19-02-02 07:50:28, Fabio Estevam wrote:
> Hi Abel,
>
> On Fri, Feb 1, 2019 at 2:43 PM Abel Vesa <abel.vesa@nxp.com> wrote:
> >
> > The third version is here:
> > https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.denx.de%2Fpipermail%2Fu-boot%2F2019-January%2F356903.html&amp;data=02%7C01%7Cabel.vesa%40nxp.com%7Ca93c33315b5b492ca15308d688f3e275%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636846978387908349&amp;sdata=wQrrLoMyouM5vdUlfXI325wqZYt4tTa5WTRJsgwMEz0%3D&amp;reserved=0
> >
> > So, this time I hope I got it right. Before, I was stupidly trying
> > to put a fit in another fit without a really good reason. To my
> > excuse, that was working even with the spl_image->os set to 0,
> > bug which I (hope) I fixed in the first patch (a new one)
> > of this series.
>
> I am happy with the entire series.
>
> One more question: do we get build error when the SPL gets larger than 64kB?

If the SPL size (without the dtb appended) is larger then yes, the build fails.
Trouble is if the SPL (without the dtb appended) is, lets say, 63kB and
then the dtb is larger than 1kB. Then there is no mechanism in place to check that
and it will just fail to boot without giving any clues why. But this is a totally
unrelated problem from this patchset's point of view and I think it impacts all
the platforms that support SPL with DM.