public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] dfu: mmc: call fs functions instead of run_command
Date: Wed, 30 Jan 2019 22:38:03 +0100	[thread overview]
Message-ID: <20190130223803.37fa512f@jawa> (raw)
In-Reply-To: <08f7f4c4-bf7a-90b2-8534-d5293b17ba1f@wwwdotorg.org>

Hi Stephen, Tom,

> On 1/25/19 11:58 AM, Simon Goldschmidt wrote:
> > This unbreaks dfu mmc_file_op which is currently broken since using
> > the load cmd on a buffer from heap is not allowed - added with
> > commit aa3c609e2be5 ("fs: prevent overwriting reserved memory")
> > 
> > Fixes: commit aa3c609e2be5 ("fs: prevent overwriting reserved
> > memory") Reported-by: Stephen Warren <swarren@wwwdotorg.org>
> > Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
> > Tested-by: Stephen Warren <swarren@nvidia.com>  
> 
> Any chance we could get this applied (directly to u-boot/master) to
> fix the rampant test failures? Thanks.

Tom, I've acked this patch (in other mail). Please feel free to apply
it to -master branch.

Thanks for fixing it :-) (the code was really old and I'm glad that it
was updated to fs_* functions).

Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190130/aaaa9d2b/attachment.sig>

  reply	other threads:[~2019-01-30 21:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-25 18:58 [U-Boot] [PATCH] dfu: mmc: call fs functions instead of run_command Simon Goldschmidt
2019-01-30 18:44 ` Stephen Warren
2019-01-30 21:38   ` Lukasz Majewski [this message]
2019-01-30 21:35 ` Lukasz Majewski
2019-01-31  2:42 ` [U-Boot] " Tom Rini
2019-01-31 16:35   ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190130223803.37fa512f@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox