public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: andy.yan at rock-chips.com <andy.yan@rock-chips.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now
Date: Fri, 1 Feb 2019 09:32:12 +0800	[thread overview]
Message-ID: <201902010932116387593@rock-chips.com> (raw)
In-Reply-To: E1gpJd4-0008JF-BU@mail.theobroma-systems.com

Hi:

> This function causes a 5-second delay and stops the display working on
> minnie. This code should be in a driver and should only be enabled by
> a device-tree property, so that it does not affect devices which do not
> have this feature.
> 
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> 
>  arch/arm/mach-rockchip/boot_mode.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
 
》Applied to u-boot-rockchip, thanks!


According to the previous discussing, shouldn‘t this be fixed by  by setting CONFIG_BOOT_MODE_REG=0 ?
All rockchip products need this function,we really don't want it be turned off.
 

  reply	other threads:[~2019-02-01  1:32 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-29 13:16 [U-Boot] [PATCH 1/2] rockchip: chromebook_minnie: Enable sound Simon Glass
2018-12-29 13:16 ` [U-Boot] [PATCH 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now Simon Glass
2018-12-29 17:57   ` Philipp Tomsich
2018-12-29 18:00     ` Philipp Tomsich
2019-01-10 12:56       ` Simon Glass
2019-01-03  7:32   ` [U-Boot] [PATCH 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now[Please note, mail behalf by 3vnmnxammciszqnjoyvtpbt.vynrlcly.fhunyvjr-jopwz.jvt@chromium-sendgmr.bounces.google.com] Kever Yang
2019-01-03 21:29     ` Simon Glass
2019-01-03 21:36       ` Philipp Tomsich
2019-01-31 21:12   ` [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now Philipp Tomsich
2019-02-01  1:32     ` andy.yan at rock-chips.com [this message]
2019-02-01  8:38       ` Philipp Tomsich
2019-02-01  8:39         ` Philipp Tomsich
2019-02-01  9:32     ` [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-bounces@lists.denx.de代发】 Kever Yang
2019-02-01  9:34       ` Philipp Tomsich
2019-02-01 10:26         ` Philipp Tomsich
2019-02-01 14:39           ` Simon Glass
2019-02-12  3:03           ` Andy Yan
2019-02-12 15:31             ` Simon Glass
2019-03-06 10:52               ` [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-bounces@lists.denx.de代发】【请注意,邮件由sjg@google.com代发】 Andy Yan
2019-03-11  2:30                 ` Simon Glass
2019-03-11 13:04                   ` Philipp Tomsich
2019-03-12  1:23                     ` [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now Kever Yang
2019-03-18 11:58                       ` Simon Glass
2019-03-18 12:07                         ` Philipp Tomsich
2019-03-12  6:28                   ` [U-Boot] [U-Boot, 2/2] rockchip: Drop call to rockchip_dnl_mode_check() for now【请注意,邮件由u-boot-bounces@lists.denx.de代发】【请注意,邮件由sjg@google.com代发】 Andy Yan
2019-01-27 17:31 ` [U-Boot] [U-Boot, 1/2] rockchip: chromebook_minnie: Enable sound Philipp Tomsich
2019-01-28  9:12 ` Philipp Tomsich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201902010932116387593@rock-chips.com \
    --to=andy.yan@rock-chips.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox