From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Fri, 1 Feb 2019 22:08:35 +0100 Subject: [U-Boot] [PATCH v4 01/20] common: spl_fit: Fix the spl_fit_image_get_os for FIT_IMAGE_TINY In-Reply-To: <1549039198-16674-2-git-send-email-abel.vesa@nxp.com> References: <1549039198-16674-1-git-send-email-abel.vesa@nxp.com> <1549039198-16674-2-git-send-email-abel.vesa@nxp.com> Message-ID: <20190201220835.4ad6a041@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Abel, > There is not really reducing codesize here since there is only > a call. Yes, I also haven't observed any change. > The function is always built in if CONFIG_$(SPL_TPL_)FIT is > set. Plus, there was a change in behavior if CONFIG_SPL_OS_BOOT is > defined. If CONFIG_FIT_IMAGE_TINY is defined, the > spl_fit_image_get_os was returning -ENOTSUPP and then if > CONFIG_SPL_OS_BOOT was also defined, the spl_image->os was left set > to 0 which in turn was skipping the fdt appending resulting in > boot-up failure. > > Fixes: 337bbb6297775e spl: fit: add SPL_FIT_IMAGE_TINY config to > reduce code-size Signed-off-by: Abel Vesa However, this commit fixes the issue (the board didn't hang anymore after SPL loading), hence Tested-by: Lukasz Majewski I've tested it on mccmon6 HW (imx6q). Just to share - for me CONFIG_USE_TINY_PRINTF=y gave reduction of SPL size from 38KiB to 34KiB. Thanks for your commit. > --- > common/spl/spl_fit.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c > index db43626..a87d02d 100644 > --- a/common/spl/spl_fit.c > +++ b/common/spl/spl_fit.c > @@ -333,11 +333,7 @@ static int spl_fit_record_loadable(const void > *fit, int images, int index, > static int spl_fit_image_get_os(const void *fit, int noffset, > uint8_t *os) { > -#if CONFIG_IS_ENABLED(FIT_IMAGE_TINY) > - return -ENOTSUPP; > -#else > return fit_image_get_os(fit, noffset, os); > -#endif > } > > int spl_load_simple_fit(struct spl_image_info *spl_image, Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: