[U-Boot] [PATCH 1/2] tools/imx8m_image.sh: remove bashism

Otavio Salvador
2019-04-01T13:56:26Z

On Mon, Apr 1, 2019 at 10:46 AM Stefano Babic <sbabic@denx.de> wrote:
> > This is still broken and the proposed patch does fix it. We should get
> > this merged for 2019.04 release.
> >
> > Please Stefano, consider this for release (be it through your branch
> > for directly by Tom).
> >
>
> The thing is in which conditions this is broken and why it should be
> fixed here and in this way. Yes, I admit, I have not pondered this as a
> big issue - it could be also fixed replacing dash with bash on
> Debian-like distros, and I guess also on not-debian. And I am quite sure
> we cannot ensure compatibility with all possible shell that a customer
> will try , from csh to some exotic variant. Why is this so important to
> be rapidely fixed here ?

The dash uses POSIX syntax and it failing on this is a bad signal.
Asking people to change the default system shell to build U-Boot is no
sense.

We cannot ensure compatibility, for sure, but using bashism makes it
worse and non POSIX compatible.

--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750