[U-Boot] [PATCH v4 22/22] pcm052: bk4: Add board_phy_config() for BK4 to setup ksz8081 phy

Joe Hershberger
2019-03-04T22:26:30Z

On Wed, Feb 13, 2019 at 3:51 PM Lukasz Majewski <lukma@denx.de> wrote:
>
> BK4 requires setup of 50MHz reference clock for its KSZ8081 PHY devices.
>
> Signed-off-by: Lukasz Majewski <lukma@denx.de>

Acked-by: Joe Hershberger <joe.hershberger@ni.com>

> ---
>
> Changes in v4: None
> Changes in v3: None
> Changes in v2: None
>
> board/phytec/pcm052/pcm052.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/board/phytec/pcm052/pcm052.c b/board/phytec/pcm052/pcm052.c
> index 1e443a5850..c30df5df9d 100644
> --- a/board/phytec/pcm052/pcm052.c
> +++ b/board/phytec/pcm052/pcm052.c
> @@ -15,6 +15,7 @@
> #include <asm/arch/clock.h>
> #include <led.h>
> #include <environment.h>
> +#include <miiphy.h>
>
> DECLARE_GLOBAL_DATA_PTR;
>
> @@ -382,6 +383,21 @@ int board_late_init(void)
>
> return 0;
> }
> +
> +/**
> + * KSZ8081
> + */
> +#define MII_KSZ8081_REFERENCE_CLOCK_SELECT 0x1f
> +#define RMII_50MHz_CLOCK 0x8180
> +
> +int board_phy_config(struct phy_device *phydev)
> +{
> + /* Set 50 MHz reference clock */
> + phy_write(phydev, MDIO_DEVAD_NONE, MII_KSZ8081_REFERENCE_CLOCK_SELECT,
> + RMII_50MHz_CLOCK);

Is it reasonable to use the clock infrastructure? Not necessarily
instead of fixing this now, but would be a good direction.

> +
> + return genphy_config(phydev);
> +}
> #endif /* CONFIG_TARGET_BK4R1 */
>
> int checkboard(void)
> --
> 2.11.0
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot