From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 01/22] net: FEC: Add compatible for vybrid (vf610) to reuse fec_mxc.c driver
Date: Tue, 12 Feb 2019 07:51:59 +0100 [thread overview]
Message-ID: <20190212075159.6f370beb@jawa> (raw)
In-Reply-To: <4a54e5dada451cc2f88af4b22210039041aa2989.camel@toradex.com>
Hi Marcel,
> Hi Lukasz
>
> On Sun, 2019-02-03 at 00:02 +0100, Lukasz Majewski wrote:
> > The NXP's FEC driver can be reused on vf610 device (with DM).
> >
> > Signed-off-by: Lukasz Majewski <lukma@denx.de>
> > Reviewed-by: Stefan Agner <stefan.agner@toradex.com>
> > ---
> >
> > Changes in v3: None
> > Changes in v2: None
> >
> > drivers/net/fec_mxc.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c
> > index 1a59026a62..5ff49224f4 100644
> > --- a/drivers/net/fec_mxc.c
> > +++ b/drivers/net/fec_mxc.c
> > @@ -1486,6 +1486,7 @@ static const struct udevice_id fecmxc_ids[] =
> > { { .compatible = "fsl,imx6ul-fec" },
> > { .compatible = "fsl,imx53-fec" },
> > { .compatible = "fsl,imx7d-fec" },
> > + { .compatible = "fsl,mvf600-fec" },
> > { }
> > };
>
> For some reason while the FEC prior to DM was rock solid on Vybrid
> with DM it at times only sends stuff but refuses to receive packets.
> Do you recall having any such issues? Could it have to do with us
> using FEC1 by default rather than FEC0? But then at times it works
> just fine again which is rather strange...
I had also some problems when I switched to DM (but for other NXP
IMX6Q based board - mccmon6). It turned out that the time between probe
in the driver and first read of MDIO was just as in spec (or too short).
As a result the PHY was sometimes in uninitialized state, and silently
read 0xFFFFFFFF as ID, which prevent us from normal work.
The fix in this case was to increase the delay between powering up PHY
and exiting the ETH driver probe:
http://patchwork.ozlabs.org/patch/1034050/
Please check if this patch (from this series):
"pcm052: bk4: Add board_phy_config() for BK4 to setup ksz8081 phy"
is not solving your problem.
>
> Cheers
>
> Marcel
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190212/c328aaca/attachment.sig>
next prev parent reply other threads:[~2019-02-12 6:51 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-02 23:02 [U-Boot] [PATCH v3 00/22] imx: vybrid: Update BK4 and PCM052 boards to only use DM/DTS Lukasz Majewski
2019-02-02 23:02 ` [U-Boot] [PATCH v3 01/22] net: FEC: Add compatible for vybrid (vf610) to reuse fec_mxc.c driver Lukasz Majewski
2019-02-12 0:08 ` Marcel Ziswiler
2019-02-12 6:51 ` Lukasz Majewski [this message]
2019-02-02 23:02 ` [U-Boot] [PATCH v3 02/22] net: Kconfig: FEC: Add dependency on VF610 Lukasz Majewski
2019-02-02 23:02 ` [U-Boot] [PATCH v3 03/22] vybrid: ddr: Extend vf610-pinfunc.h with DDR pads definitions Lukasz Majewski
2019-02-12 0:04 ` Marcel Ziswiler
2019-02-12 6:44 ` Lukasz Majewski
2019-02-02 23:02 ` [U-Boot] [PATCH v3 04/22] vybrid: clock: Provide enable_i2c_clk() function for Vybrid Lukasz Majewski
2019-02-07 8:35 ` Stefan Agner
2019-02-12 0:09 ` Marcel Ziswiler
2019-02-02 23:02 ` [U-Boot] [PATCH v3 05/22] pcm052: board: Do not enable I2C2 code in the board file Lukasz Majewski
2019-02-12 0:12 ` Marcel Ziswiler
2019-02-02 23:02 ` [U-Boot] [PATCH v3 06/22] vybrid: Define the imx_get_mac_from_fuse() as a __weak function Lukasz Majewski
2019-02-02 23:02 ` [U-Boot] [PATCH v3 07/22] pcm052: board: Remove "m4go" command as it is superseded by "bootaux" Lukasz Majewski
2019-02-13 14:51 ` Marcel Ziswiler
2019-02-13 15:01 ` Lukasz Majewski
2019-02-02 23:02 ` [U-Boot] [PATCH v3 08/22] pcm052: board: vybrid: Update the board name for BK4 device Lukasz Majewski
2019-02-02 23:02 ` [U-Boot] [PATCH v3 09/22] ARM: DTS: vybrid: Update vf.dtsi file to descibe more vf610 hardware Lukasz Majewski
2019-02-12 0:13 ` Marcel Ziswiler
2019-02-02 23:02 ` [U-Boot] [PATCH v3 10/22] pcm052: board: cosmetic: Add copyright notice to pcm052.c Lukasz Majewski
2019-02-02 23:02 ` [U-Boot] [PATCH v3 11/22] ARM: DTS: Update pcm052 based dts files (bk4r1/pcm052) Lukasz Majewski
2019-02-02 23:02 ` [U-Boot] [PATCH v3 12/22] ARM: DTS: Provide vf610-bk4r1-u-boot.dtsi for U-Boot specific properties Lukasz Majewski
2019-02-02 23:02 ` [U-Boot] [PATCH v3 13/22] defconfig: bk4/pcm052: Update bk4r1|pcm052_defconfig to support DM/DT Lukasz Majewski
2019-02-02 23:02 ` [U-Boot] [PATCH v3 14/22] config: pcm052: Use SZ_X{MK} from linux/sizes.h for include/configs/pcm052.h Lukasz Majewski
2019-02-12 0:16 ` Marcel Ziswiler
2019-02-02 23:02 ` [U-Boot] [PATCH v3 15/22] config: bk4: Update include/configs/bk4r1.h file Lukasz Majewski
2019-02-02 23:02 ` [U-Boot] [PATCH v3 16/22] pcm052: board: Remove in-board setup code (it is now replaced by DM setup) Lukasz Majewski
2019-02-02 23:02 ` [U-Boot] [PATCH v3 17/22] config: bk4: Update u-boot script to support recovery via SD card Lukasz Majewski
2019-02-02 23:02 ` [U-Boot] [PATCH v3 18/22] config: bk4: Update u-boot envs to support NOR memories initial setup Lukasz Majewski
2019-02-02 23:02 ` [U-Boot] [PATCH v3 19/22] pcm052: bk4: sdcard: Add support for SD card booting/recovery Lukasz Majewski
2019-02-02 23:02 ` [U-Boot] [PATCH v3 20/22] pcm052: board: Add code to setup LED default states Lukasz Majewski
2019-02-02 23:02 ` [U-Boot] [PATCH v3 21/22] pcm052: mac: Provide board specific imx_get_mac_from_fuse() function Lukasz Majewski
2019-02-02 23:02 ` [U-Boot] [PATCH v3 22/22] pcm052: bk4: Add board_phy_config() for BK4 to setup ksz8081 phy Lukasz Majewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212075159.6f370beb@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox