From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC v2 00/15] dm, efi: integrate efi objects into DM
Date: Tue, 12 Feb 2019 17:30:09 +0900 [thread overview]
Message-ID: <20190212083008.GO20286@linaro.org> (raw)
In-Reply-To: <CAPnjgZ3HT-ovLSgfwJvyOxG1rtUOCt1x1eJHfGxv4CXL3ghUKA@mail.gmail.com>
On Sat, Feb 09, 2019 at 05:04:19PM -0600, Simon Glass wrote:
> Hi Takahiro,
>
> On Fri, 8 Feb 2019 at 02:14, AKASHI Takahiro <takahiro.akashi@linaro.org> wrote:
> >
> > # bootefi doesn't work with this patch set yet
> >
> > This patch set came from the past discussion[1] on my "removable device
> > support" patch and is intended to be an attempt to integrate efi objects
> > into u-boot's Driver Model as much seamlessly as possible.
> >
> > [1] https://lists.denx.de/pipermail/u-boot/2019-January/354010.html
>
> Some general comments:
>
> protocol_list: Can you use DM_GET_DRIVER? It should be more efficient
Okay.
> efi_open_protocol_information:
> - rename of protocol to protocol_guid should be in a separate patch
Okay, but I may will rename other argument names instead.
> u-boot - please use 'U-Boot' consistently
Sure.
> Your patch to rename UCLASS_EFI -> UCLASS_EFI_DRIVER still leaves
> UCLASS_EFI remaining. Can you mention why>
>
> It says efi_root is for backward compatibility. Just temporary? I
> could not quite figure that out.
The concept of "efi_root" is a discussion.
> Use if (IS_ENABLED()) instead of #ifdef where you can.
Okay
> I am very encouraged by this series as it genuinely unifies EFI with
> DM. Re your comment about wrapper code, I suspect that might become
> clearer once the data structures are unified.
Your comments also encourage me very much.
Thanks!
-Takahiro Akashi
> Regards,
> Simon
prev parent reply other threads:[~2019-02-12 8:30 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-08 8:15 [U-Boot] [RFC v2 00/15] dm, efi: integrate efi objects into DM AKASHI Takahiro
2019-02-08 8:15 ` [U-Boot] [RFC v2 01/15] efi_loader: efi objects and protocols as DM devices AKASHI Takahiro
2019-02-08 17:47 ` Heinrich Schuchardt
2019-02-12 4:55 ` AKASHI Takahiro
2019-02-08 8:15 ` [U-Boot] [RFC v2 02/15] efi_loader: boottime: convert efi_loaded_image_obj to DM AKASHI Takahiro
2019-02-08 17:53 ` Heinrich Schuchardt
2019-02-12 5:07 ` AKASHI Takahiro
2019-02-12 6:47 ` Heinrich Schuchardt
2019-02-12 7:35 ` AKASHI Takahiro
2019-02-08 8:15 ` [U-Boot] [RFC v2 03/15] efi_loader: image_loader: aligned with DM AKASHI Takahiro
2019-02-08 8:15 ` [U-Boot] [RFC v2 04/15] efi_driver: rename UCLASS_EFI to UCLASS_EFI_DRIVER AKASHI Takahiro
2019-02-08 8:15 ` [U-Boot] [RFC v2 05/15] efi_loader: convert efi_root_node to DM AKASHI Takahiro
2019-02-08 8:15 ` [U-Boot] [RFC v2 06/15] efi_loader: device path: convert efi_device_path " AKASHI Takahiro
2019-02-08 8:15 ` [U-Boot] [RFC v2 07/15] efi_loader: unicode_collation: converted " AKASHI Takahiro
2019-02-08 8:15 ` [U-Boot] [RFC v2 08/15] efi_loader: console: convert efi console input/output " AKASHI Takahiro
2019-02-08 8:15 ` [U-Boot] [RFC v2 09/15] efi_loader: net: convert efi_net_obj " AKASHI Takahiro
2019-02-08 8:15 ` [U-Boot] [RFC v2 10/15] efi_loader: gop: convert efi_gop_obj " AKASHI Takahiro
2019-02-08 8:15 ` [U-Boot] [RFC v2 11/15] dm: blk: add UCLASS_PARTITION AKASHI Takahiro
2019-02-08 8:15 ` [U-Boot] [RFC v2 12/15] efi_loader: disk: convert efi_disk_obj to DM AKASHI Takahiro
2019-02-08 8:15 ` [U-Boot] [RFC v2 13/15] drivers: align block device drivers with DM-efi integration AKASHI Takahiro
2019-02-08 8:15 ` [U-Boot] [RFC v2 14/15] efi_driver: converted to DM AKASHI Takahiro
2019-02-08 8:15 ` [U-Boot] [RFC v2 15/15] cmd: efidebug: aligned with DM-efi integration AKASHI Takahiro
2019-02-08 9:30 ` [U-Boot] [RFC v2 00/15] dm, efi: integrate efi objects into DM Heinrich Schuchardt
2019-02-09 23:00 ` Simon Glass
2019-02-12 7:24 ` AKASHI Takahiro
2019-02-12 9:47 ` Heinrich Schuchardt
2019-03-19 1:25 ` Simon Glass
2019-02-09 20:08 ` Simon Glass
2019-02-12 8:25 ` AKASHI Takahiro
2019-02-09 23:04 ` Simon Glass
2019-02-12 8:30 ` AKASHI Takahiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190212083008.GO20286@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox