public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 5/9] arm: exynos: Wait till ADC stabilizes before checking Odroid HC1 revision
Date: Wed, 13 Feb 2019 17:46:44 +0100	[thread overview]
Message-ID: <20190213164648.26579-6-krzk@kernel.org> (raw)
In-Reply-To: <20190213164648.26579-1-krzk@kernel.org>

Fix detection of Odroid HC1 (Exynos5422) after reboot if kernel disabled
the LDO4/VDD_ADC regulator.

The LDO4 supplies both ADC block and the ADC input AIN9.  Voltage on
AIN9 will rise slowly, so be patient and wait for it to stabilize.

First reads on Odroid HC1 return 305, 1207, 1297 and finally 1308
(reference value is 1309).

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 board/samsung/common/exynos5-dt-types.c | 38 ++++++++++++++++++++++++-
 1 file changed, 37 insertions(+), 1 deletion(-)

diff --git a/board/samsung/common/exynos5-dt-types.c b/board/samsung/common/exynos5-dt-types.c
index af711e727a78..8aed64183837 100644
--- a/board/samsung/common/exynos5-dt-types.c
+++ b/board/samsung/common/exynos5-dt-types.c
@@ -57,12 +57,48 @@ static unsigned int odroid_get_rev(void)
 	return 0;
 }
 
+/*
+ * Read ADC at least twice and check the resuls.  If regulator providing voltage
+ * on to measured point was just turned on, first reads might require time
+ * to stabilize.
+ */
+static int odroid_get_adc_val(unsigned int *adcval)
+{
+	unsigned int adcval_prev = 0;
+	int ret, retries = 20;
+
+	ret = adc_channel_single_shot("adc", CONFIG_ODROID_REV_AIN,
+				      &adcval_prev);
+	if (ret)
+		return ret;
+
+	while (retries--) {
+		mdelay(5);
+
+		ret = adc_channel_single_shot("adc", CONFIG_ODROID_REV_AIN,
+					      adcval);
+		if (ret)
+			return ret;
+
+		/*
+		 * If difference between ADC reads is less than 3%,
+		 * accept the result
+		 */
+		if ((100 * abs(*adcval - adcval_prev) / adcval_prev) < 3)
+			return ret;
+
+		adcval_prev = *adcval;
+	}
+
+	return ret;
+}
+
 static int odroid_get_board_type(void)
 {
 	unsigned int adcval;
 	int ret, i;
 
-	ret = adc_channel_single_shot("adc", CONFIG_ODROID_REV_AIN, &adcval);
+	ret = odroid_get_adc_val(&adcval);
 	if (ret)
 		goto rev_default;
 
-- 
2.17.1

  parent reply	other threads:[~2019-02-13 16:46 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-13 16:46 [U-Boot] [PATCH v2 0/9] arm: exynos: Fix reboot on Odroid HC1 Krzysztof Kozlowski
2019-02-13 16:46 ` [U-Boot] [PATCH v2 1/9] adc: exynos-adc: Fix wrong bit operation used to stop the ADC Krzysztof Kozlowski
2019-02-15  6:54   ` Lukasz Majewski
2019-02-13 16:46 ` [U-Boot] [PATCH v2 2/9] power: regulator: s2mps11: Fix step for LDO27 and LDO35 Krzysztof Kozlowski
2019-02-15  6:55   ` Lukasz Majewski
2019-02-13 16:46 ` [U-Boot] [PATCH v2 3/9] arm: exynos: Detect revision later, when all resources are ready Krzysztof Kozlowski
2019-02-13 16:46 ` [U-Boot] [PATCH v2 4/9] arm: exynos: odroid-xu3: Display info late to have proper type Krzysztof Kozlowski
2019-02-14  7:37   ` Krzysztof Kozlowski
2019-02-13 16:46 ` Krzysztof Kozlowski [this message]
2019-02-15  7:15   ` [U-Boot] [PATCH v2 5/9] arm: exynos: Wait till ADC stabilizes before checking Odroid HC1 revision Lukasz Majewski
2019-02-15 10:06     ` Krzysztof Kozlowski
2019-02-16  9:28     ` Krzysztof Kozlowski
2019-02-17 22:31       ` Lukasz Majewski
2019-02-13 16:46 ` [U-Boot] [PATCH v2 6/9] regulator: Add support for ramp delay Krzysztof Kozlowski
2019-02-13 16:46 ` [U-Boot] [PATCH v2 7/9] power: regulator: s2mps11: Add enable delay Krzysztof Kozlowski
2019-02-15  7:03   ` Lukasz Majewski
2019-02-15 10:11     ` Krzysztof Kozlowski
2019-02-15 10:55       ` Lukasz Majewski
2019-02-15 17:11   ` Simon Glass
2019-02-16  8:37     ` Krzysztof Kozlowski
2019-02-13 16:46 ` [U-Boot] [PATCH v2 8/9] arm: dts: exynos: Add supply for ADC block to Odroid XU3 family Krzysztof Kozlowski
2019-02-15  7:01   ` Lukasz Majewski
2019-02-13 16:46 ` [U-Boot] [PATCH v2 9/9] arm: dts: exynos: Add ramp delay property to LDO regulators " Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190213164648.26579-6-krzk@kernel.org \
    --to=krzk@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox