[U-Boot] [PATCH v2 7/9] power: regulator: s2mps11: Add enable delay

Simon Glass
2019-02-15T17:11:34Z

Hi Krzysztof,

On Wed, 13 Feb 2019 at 17:47, Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> According to datasheet, the output on LDO regulators will start
> appearing after 10-15 us.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/power/regulator/s2mps11_regulator.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/regulator/s2mps11_regulator.c b/drivers/power/regulator/s2mps11_regulator.c
> index 723d27f67c9a..1f1581852ee2 100644
> --- a/drivers/power/regulator/s2mps11_regulator.c
> +++ b/drivers/power/regulator/s2mps11_regulator.c
> @@ -551,7 +551,14 @@ static int ldo_get_enable(struct udevice *dev)
>
> static int ldo_set_enable(struct udevice *dev, bool enable)
> {
> - return s2mps11_ldo_enable(dev, PMIC_OP_SET, &enable);
> + int ret;
> +
> + ret = s2mps11_ldo_enable(dev, PMIC_OP_SET, &enable);

How about:

if (ret)
return ret;

> +
> + /* Wait the "enable delay" for voltage to start to rise */
> + udelay(15);
> +
> + return ret;

return 0;

> }
>
> static int ldo_get_mode(struct udevice *dev)
> --
> 2.17.1
>

Regards,
Simon