[U-Boot] [PATCH 2/2] mtd: ubi, ubifs debug: Use pr_debug instead of pr_crit

[U-Boot] [PATCH 2/2] mtd: ubi, ubifs debug: Use pr_debug instead of pr_crit

[Eran Matityahu]

Before printk.h was introduced and MTDDEBUG was removed,
pr_crit() was calling MTDDEBUG(), which was since then
replaced by the current pr_debug().

pr_debug is more appropriate here.

Signed-off-by: Eran Matityahu <eran.m@variscite.com>
---
 drivers/mtd/ubi/debug.h | 2 +-
 fs/ubifs/debug.h        | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/ubi/debug.h b/drivers/mtd/ubi/debug.h
index d853520..2c2faaf 100644
--- a/drivers/mtd/ubi/debug.h
+++ b/drivers/mtd/ubi/debug.h
@@ -29,7 +29,7 @@ void ubi_dump_vid_hdr(const struct ubi_vid_hdr *vid_hdr);
 #else
 #define ubi_assert(expr)  do {                                               \
 	if (unlikely(!(expr))) {                                             \
-		pr_crit("UBI assert failed in %s at %u\n",                   \
+		pr_debug("UBI assert failed in %s at %u\n",                  \
 		       __func__, __LINE__);                                  \
 		dump_stack();                                                \
 	}                                                                    \
diff --git a/fs/ubifs/debug.h b/fs/ubifs/debug.h
index bad0c67..5f6e127 100644
--- a/fs/ubifs/debug.h
+++ b/fs/ubifs/debug.h
@@ -167,7 +167,7 @@ struct ubifs_global_debug_info {
 #else
 #define ubifs_assert(expr) do {                                                \
 	if (unlikely(!(expr))) {                                               \
-		pr_crit("UBIFS assert failed in %s at %u\n",                   \
+		pr_debug("UBIFS assert failed in %s at %u\n",                  \
 		       __func__, __LINE__);                                    \
 		dump_stack();                                                  \
 	}                                                                      \
@@ -176,7 +176,7 @@ struct ubifs_global_debug_info {
 #define ubifs_assert_cmt_locked(c) do {                                        \
 	if (unlikely(down_write_trylock(&(c)->commit_sem))) {                  \
 		up_write(&(c)->commit_sem);                                    \
-		pr_crit("commit lock is not locked!\n");                       \
+		pr_debug("commit lock is not locked!\n");                      \
 		ubifs_assert(0);                                               \
 	}                                                                      \
 } while (0)
-- 
1.9.1

[U-Boot] [PATCH 2/2] mtd: ubi, ubifs debug: Use pr_debug instead of pr_crit

[Heiko Schocher]

Hello Eran,

Am 13.02.2019 um 19:56 schrieb Eran Matityahu:
> Before printk.h was introduced and MTDDEBUG was removed,
> pr_crit() was calling MTDDEBUG(), which was since then
> replaced by the current pr_debug().
> 
> pr_debug is more appropriate here.
> 
> Signed-off-by: Eran Matityahu <eran.m@variscite.com>
> ---
>   drivers/mtd/ubi/debug.h | 2 +-
>   fs/ubifs/debug.h        | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Heiko Schocher <hs@denx.de>

queued for next merge window.

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de

[U-Boot] [PATCH 2/2] mtd: ubi, ubifs debug: Use pr_debug instead of pr_crit

[Heiko Schocher]

Hello Eran,

Am 13.02.2019 um 19:56 schrieb Eran Matityahu:
> Before printk.h was introduced and MTDDEBUG was removed,
> pr_crit() was calling MTDDEBUG(), which was since then
> replaced by the current pr_debug().
> 
> pr_debug is more appropriate here.
> 
> Signed-off-by: Eran Matityahu <eran.m@variscite.com>
> ---
>   drivers/mtd/ubi/debug.h | 2 +-
>   fs/ubifs/debug.h        | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)

Applied to uboot-ubi.git master

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de