From: Michael Trimarchi <michael@amarulasolutions.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH V2 1/3] sunxi: Use clrsetbits_le32 instead of multiple instruction
Date: Thu, 14 Feb 2019 16:58:31 +0100 [thread overview]
Message-ID: <20190214155833.11984-1-michael@amarulasolutions.com> (raw)
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
V1->V2: none
---
arch/arm/mach-sunxi/dram_sun8i_a33.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/arch/arm/mach-sunxi/dram_sun8i_a33.c b/arch/arm/mach-sunxi/dram_sun8i_a33.c
index 1da2727f98..83212aaddf 100644
--- a/arch/arm/mach-sunxi/dram_sun8i_a33.c
+++ b/arch/arm/mach-sunxi/dram_sun8i_a33.c
@@ -148,12 +148,8 @@ static void auto_set_timing_para(struct dram_para *para)
reg_val = (tcksrx << 24) | (tcksre << 16) | (tckesr << 8) | (tcke << 0);
writel(reg_val, &mctl_ctl->dramtmg5);
/* Set two rank timing and exit self-refresh timing */
- reg_val = readl(&mctl_ctl->dramtmg8);
- reg_val &= ~(0xff << 8);
- reg_val &= ~(0xff << 0);
- reg_val |= (0x33 << 8);
- reg_val |= (0x8 << 0);
- writel(reg_val, &mctl_ctl->dramtmg8);
+ clrsetbits_le32(&mctl_ctl->dramtmg8, (0xff << 8) | (0xff << 0),
+ 0x33 << 8 | (0x8 << 0));
/* Set phy interface time */
reg_val = (0x2 << 24) | (t_rdata_en << 16) | (0x1 << 8)
| (wr_latency << 0);
--
2.17.1
next reply other threads:[~2019-02-14 15:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-14 15:58 Michael Trimarchi [this message]
2019-02-14 15:58 ` [U-Boot] [PATCH V2 2/3] sunxi: Don't change the rank in dram size detection in A33 Michael Trimarchi
2019-02-14 15:58 ` [U-Boot] [PATCH V2 3/3] sunxi: Fix A33 memory initialization Michael Trimarchi
2019-02-14 16:36 ` Philipp Tomsich
2019-02-14 16:40 ` Michael Nazzareno Trimarchi
2019-02-14 21:24 ` André Przywara
2019-02-15 10:18 ` Philipp Tomsich
2019-02-15 11:31 ` Andre Przywara
2019-02-15 11:40 ` Philipp Tomsich
2019-02-15 16:01 ` Michael Nazzareno Trimarchi
2019-02-15 16:09 ` Andre Przywara
2019-02-18 9:36 ` [U-Boot] [PATCH V2 1/3] sunxi: Use clrsetbits_le32 instead of multiple instruction Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190214155833.11984-1-michael@amarulasolutions.com \
--to=michael@amarulasolutions.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox