From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Trimarchi Date: Thu, 14 Feb 2019 16:58:32 +0100 Subject: [U-Boot] [PATCH V2 2/3] sunxi: Don't change the rank in dram size detection in A33 In-Reply-To: <20190214155833.11984-1-michael@amarulasolutions.com> References: <20190214155833.11984-1-michael@amarulasolutions.com> Message-ID: <20190214155833.11984-2-michael@amarulasolutions.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Change the size create a glitch in the clken signal on second bank. According to the ddr manual the clken need to be sent accros the reset signal coming the cpu. The rank is calculated just before this function is called and the mctl_set_cr should not change this value anymore Signed-off-by: Michael Trimarchi --- V1->V2: Adjust commit description --- arch/arm/mach-sunxi/dram_sun8i_a33.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/arch/arm/mach-sunxi/dram_sun8i_a33.c b/arch/arm/mach-sunxi/dram_sun8i_a33.c index 83212aaddf..d73a93a132 100644 --- a/arch/arm/mach-sunxi/dram_sun8i_a33.c +++ b/arch/arm/mach-sunxi/dram_sun8i_a33.c @@ -45,14 +45,12 @@ static void mctl_set_cr(struct dram_para *para) static void auto_detect_dram_size(struct dram_para *para) { - u8 orig_rank = para->rank; int rows, columns; /* Row detect */ para->page_size = 512; para->seq = 1; para->rows = 16; - para->rank = 1; mctl_set_cr(para); for (rows = 11 ; rows < 16 ; rows++) { if (mctl_mem_matches(1 << (rows + 9))) /* row-column */ @@ -69,7 +67,6 @@ static void auto_detect_dram_size(struct dram_para *para) } para->seq = 0; - para->rank = orig_rank; para->rows = rows; para->page_size = 1 << columns; mctl_set_cr(para); -- 2.17.1