From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 7/9] power: regulator: s2mps11: Add enable delay
Date: Fri, 15 Feb 2019 08:03:38 +0100 [thread overview]
Message-ID: <20190215080338.6ee57649@jawa> (raw)
In-Reply-To: <20190213164648.26579-8-krzk@kernel.org>
On Wed, 13 Feb 2019 17:46:46 +0100
Krzysztof Kozlowski <krzk@kernel.org> wrote:
> According to datasheet, the output on LDO regulators will start
> appearing after 10-15 us.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> drivers/power/regulator/s2mps11_regulator.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/power/regulator/s2mps11_regulator.c
> b/drivers/power/regulator/s2mps11_regulator.c index
> 723d27f67c9a..1f1581852ee2 100644 ---
> a/drivers/power/regulator/s2mps11_regulator.c +++
> b/drivers/power/regulator/s2mps11_regulator.c @@ -551,7 +551,14 @@
> static int ldo_get_enable(struct udevice *dev)
> static int ldo_set_enable(struct udevice *dev, bool enable)
> {
> - return s2mps11_ldo_enable(dev, PMIC_OP_SET, &enable);
> + int ret;
> +
> + ret = s2mps11_ldo_enable(dev, PMIC_OP_SET, &enable);
> +
> + /* Wait the "enable delay" for voltage to start to rise */
> + udelay(15);
Isn't the enable delay provided/read from dts?
Or is it too early to have dtb parsed?
The udelay(15) seems a bit "magic" value (or is it specified in the
PMIC manual?).
> +
> + return ret;
> }
>
> static int ldo_get_mode(struct udevice *dev)
Best regards,
Lukasz Majewski
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190215/03795187/attachment.sig>
next prev parent reply other threads:[~2019-02-15 7:03 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 16:46 [U-Boot] [PATCH v2 0/9] arm: exynos: Fix reboot on Odroid HC1 Krzysztof Kozlowski
2019-02-13 16:46 ` [U-Boot] [PATCH v2 1/9] adc: exynos-adc: Fix wrong bit operation used to stop the ADC Krzysztof Kozlowski
2019-02-15 6:54 ` Lukasz Majewski
2019-02-13 16:46 ` [U-Boot] [PATCH v2 2/9] power: regulator: s2mps11: Fix step for LDO27 and LDO35 Krzysztof Kozlowski
2019-02-15 6:55 ` Lukasz Majewski
2019-02-13 16:46 ` [U-Boot] [PATCH v2 3/9] arm: exynos: Detect revision later, when all resources are ready Krzysztof Kozlowski
2019-02-13 16:46 ` [U-Boot] [PATCH v2 4/9] arm: exynos: odroid-xu3: Display info late to have proper type Krzysztof Kozlowski
2019-02-14 7:37 ` Krzysztof Kozlowski
2019-02-13 16:46 ` [U-Boot] [PATCH v2 5/9] arm: exynos: Wait till ADC stabilizes before checking Odroid HC1 revision Krzysztof Kozlowski
2019-02-15 7:15 ` Lukasz Majewski
2019-02-15 10:06 ` Krzysztof Kozlowski
2019-02-16 9:28 ` Krzysztof Kozlowski
2019-02-17 22:31 ` Lukasz Majewski
2019-02-13 16:46 ` [U-Boot] [PATCH v2 6/9] regulator: Add support for ramp delay Krzysztof Kozlowski
2019-02-13 16:46 ` [U-Boot] [PATCH v2 7/9] power: regulator: s2mps11: Add enable delay Krzysztof Kozlowski
2019-02-15 7:03 ` Lukasz Majewski [this message]
2019-02-15 10:11 ` Krzysztof Kozlowski
2019-02-15 10:55 ` Lukasz Majewski
2019-02-15 17:11 ` Simon Glass
2019-02-16 8:37 ` Krzysztof Kozlowski
2019-02-13 16:46 ` [U-Boot] [PATCH v2 8/9] arm: dts: exynos: Add supply for ADC block to Odroid XU3 family Krzysztof Kozlowski
2019-02-15 7:01 ` Lukasz Majewski
2019-02-13 16:46 ` [U-Boot] [PATCH v2 9/9] arm: dts: exynos: Add ramp delay property to LDO regulators " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190215080338.6ee57649@jawa \
--to=lukma@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox