From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukasz Majewski Date: Fri, 15 Feb 2019 08:03:38 +0100 Subject: [U-Boot] [PATCH v2 7/9] power: regulator: s2mps11: Add enable delay In-Reply-To: <20190213164648.26579-8-krzk@kernel.org> References: <20190213164648.26579-1-krzk@kernel.org> <20190213164648.26579-8-krzk@kernel.org> Message-ID: <20190215080338.6ee57649@jawa> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, 13 Feb 2019 17:46:46 +0100 Krzysztof Kozlowski wrote: > According to datasheet, the output on LDO regulators will start > appearing after 10-15 us. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/power/regulator/s2mps11_regulator.c | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/power/regulator/s2mps11_regulator.c > b/drivers/power/regulator/s2mps11_regulator.c index > 723d27f67c9a..1f1581852ee2 100644 --- > a/drivers/power/regulator/s2mps11_regulator.c +++ > b/drivers/power/regulator/s2mps11_regulator.c @@ -551,7 +551,14 @@ > static int ldo_get_enable(struct udevice *dev) > static int ldo_set_enable(struct udevice *dev, bool enable) > { > - return s2mps11_ldo_enable(dev, PMIC_OP_SET, &enable); > + int ret; > + > + ret = s2mps11_ldo_enable(dev, PMIC_OP_SET, &enable); > + > + /* Wait the "enable delay" for voltage to start to rise */ > + udelay(15); Isn't the enable delay provided/read from dts? Or is it too early to have dtb parsed? The udelay(15) seems a bit "magic" value (or is it specified in the PMIC manual?). > + > + return ret; > } > > static int ldo_get_mode(struct udevice *dev) Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: