From mboxrd@z Thu Jan  1 00:00:00 1970
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: Sat, 16 Feb 2019 09:37:19 +0100
Subject: [U-Boot] [PATCH v2 7/9] power: regulator: s2mps11: Add enable
	delay
In-Reply-To: <CAPnjgZ2wUfq2sbnrjT-YtJAyNCfwj-UUfqpttzvrYpZLACiNQA@mail.gmail.com>
References: <20190213164648.26579-1-krzk@kernel.org>
 <20190213164648.26579-8-krzk@kernel.org>
 <CAPnjgZ2wUfq2sbnrjT-YtJAyNCfwj-UUfqpttzvrYpZLACiNQA@mail.gmail.com>
Message-ID: <20190216083719.GA24269@kozik-lap>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Fri, Feb 15, 2019 at 06:11:34PM +0100, Simon Glass wrote:
> Hi Krzysztof,
> 
> On Wed, 13 Feb 2019 at 17:47, Krzysztof Kozlowski <krzk@kernel.org> wrote:
> >
> > According to datasheet, the output on LDO regulators will start
> > appearing after 10-15 us.
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> >  drivers/power/regulator/s2mps11_regulator.c | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/regulator/s2mps11_regulator.c b/drivers/power/regulator/s2mps11_regulator.c
> > index 723d27f67c9a..1f1581852ee2 100644
> > --- a/drivers/power/regulator/s2mps11_regulator.c
> > +++ b/drivers/power/regulator/s2mps11_regulator.c
> > @@ -551,7 +551,14 @@ static int ldo_get_enable(struct udevice *dev)
> >
> >  static int ldo_set_enable(struct udevice *dev, bool enable)
> >  {
> > -       return s2mps11_ldo_enable(dev, PMIC_OP_SET, &enable);
> > +       int ret;
> > +
> > +       ret = s2mps11_ldo_enable(dev, PMIC_OP_SET, &enable);
> 
> How about:
> 
> if (ret)
>     return ret;
> 

Sure, good idea, thanks!

Best regards,
Krzysztof