[U-Boot] [PATCH 1/2] tools/imx8m_image.sh: remove bashism

Stefano Babic
2019-04-01T14:05:54Z

Hi Fabio,

On 01/04/19 15:49, Fabio Estevam wrote:
> Hi Stefano,
>
> On Mon, Apr 1, 2019 at 10:46 AM Stefano Babic <sbabic@denx.de> wrote:
>
>> The thing is in which conditions this is broken and why it should be
>> fixed here and in this way. Yes, I admit, I have not pondered this as a
>> big issue - it could be also fixed replacing dash with bash on
>> Debian-like distros, and I guess also on not-debian. And I am quite sure
>> we cannot ensure compatibility with all possible shell that a customer
>> will try , from csh to some exotic variant. Why is this so important to
>> be rapidely fixed here ?
>
> On my Ubuntu 18.04 host I cannot build U-Boot for imx8mq-evk without
> this patch, so it would be really nice if we could get Baruch's or any
> other solution that fixes this issue.

Well, it looks like too much because I have 18.04, too, and I can build.
I cannot say that Ubuntu users cannot build u-boot anymore.
I guess you have /bin/sh -> dash, and /bin/sh -> bash solves the
problem, too. Or using update-alternatives, as we are in Ubuntu. I can
imagine it is disturbing in docker because a further step in
docker-compose to set up the shell is required, too.
As far as I know, default is dash (but was not dash default a long of
time ago ? I wonder this has become an issue recently, I have missed
something in the between). Nevertheless, I am still missing why this is
so important to push here when the user can set the shell and build
without issues. And travis works, too, it is also based on Ubuntu :
trusty, quite old, but I was convinced that dash was the default in
Ubuntu since a long time.

Maybe I am missing the point here...(to be honest: I put the patch in
"Changes requested" a lot of time ago and I have forgotten about it..)

Stefano

--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================