public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [RFT] configs: arndale: Use appropriate driver for Asix AX88760
@ 2019-02-21 17:08 Krzysztof Kozlowski
  2019-02-21 22:07 ` Lukasz Majewski
  0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2019-02-21 17:08 UTC (permalink / raw)
  To: u-boot

Arndale board has an Asix AX88760 USB 2.0 Hub and Fast Ethernet combo.
The appropriate driver for it is USB_ETHER_ASIX.

The mistake probably came from misinterpretation of commit e9954b867ce0
("usb: eth: add ASIX AX88179 DRIVER") which was tested on RECS5250 COM
module.  This module indeed has Exynos5250 and some similarities with
Arndale 5250 board but the USB/Ethernet chip used there is apparently
different.

Fixes: f58ad98a621c ("usb: net: migrate USB Ethernet adapters to Kconfig")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Not tested.
---
 configs/arndale_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/arndale_defconfig b/configs/arndale_defconfig
index 24422645cbac..b1f20b915889 100644
--- a/configs/arndale_defconfig
+++ b/configs/arndale_defconfig
@@ -41,4 +41,4 @@ CONFIG_USB_XHCI_HCD=y
 CONFIG_USB_XHCI_DWC3=y
 CONFIG_USB_EHCI_HCD=y
 CONFIG_USB_HOST_ETHER=y
-CONFIG_USB_ETHER_ASIX88179=y
+CONFIG_USB_ETHER_ASIX=y
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [U-Boot] [RFT] configs: arndale: Use appropriate driver for Asix AX88760
  2019-02-21 17:08 [U-Boot] [RFT] configs: arndale: Use appropriate driver for Asix AX88760 Krzysztof Kozlowski
@ 2019-02-21 22:07 ` Lukasz Majewski
  0 siblings, 0 replies; 2+ messages in thread
From: Lukasz Majewski @ 2019-02-21 22:07 UTC (permalink / raw)
  To: u-boot

On Thu, 21 Feb 2019 18:08:12 +0100
Krzysztof Kozlowski <krzk@kernel.org> wrote:

> Arndale board has an Asix AX88760 USB 2.0 Hub and Fast Ethernet combo.
> The appropriate driver for it is USB_ETHER_ASIX.
> 
> The mistake probably came from misinterpretation of commit
> e9954b867ce0 ("usb: eth: add ASIX AX88179 DRIVER") which was tested
> on RECS5250 COM module.  This module indeed has Exynos5250 and some
> similarities with Arndale 5250 board but the USB/Ethernet chip used
> there is apparently different.
> 
> Fixes: f58ad98a621c ("usb: net: migrate USB Ethernet adapters to
> Kconfig") Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> ---
> 
> Not tested.
> ---
>  configs/arndale_defconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configs/arndale_defconfig b/configs/arndale_defconfig
> index 24422645cbac..b1f20b915889 100644
> --- a/configs/arndale_defconfig
> +++ b/configs/arndale_defconfig
> @@ -41,4 +41,4 @@ CONFIG_USB_XHCI_HCD=y
>  CONFIG_USB_XHCI_DWC3=y
>  CONFIG_USB_EHCI_HCD=y
>  CONFIG_USB_HOST_ETHER=y
> -CONFIG_USB_ETHER_ASIX88179=y
> +CONFIG_USB_ETHER_ASIX=y

Reviewed-by: Lukasz Majewski <lukma@denx.de>


Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190221/c00f2788/attachment.sig>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-02-21 22:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-21 17:08 [U-Boot] [RFT] configs: arndale: Use appropriate driver for Asix AX88760 Krzysztof Kozlowski
2019-02-21 22:07 ` Lukasz Majewski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox