From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, v3, 1/2] fs: fat: dynamically allocate memory for temporary buffer
Date: Thu, 21 Feb 2019 22:22:00 -0500 [thread overview]
Message-ID: <20190222032200.GO12379@bill-the-cat> (raw)
In-Reply-To: <6e8f32fe-f956-3b7a-d492-9f99dc3f41e3@monstr.eu>
On Thu, Feb 21, 2019 at 08:45:37AM +0100, Michal Simek wrote:
> Hi Tom,
>
> On 20. 02. 19 2:58, Tom Rini wrote:
> > On Mon, Feb 11, 2019 at 02:56:19PM +0800, tien.fong.chee at intel.com wrote:
> >
> >> From: Tien Fong Chee <tien.fong.chee@intel.com>
> >>
> >> Drop the statically allocated get_contents_vfatname_block and
> >> dynamically allocate a buffer only if required. This saves
> >> 64KiB of memory.
> >>
> >> Signed-off-by: Stefan Agner <stefan.ag...@toradex.com>
> >> Signed-off-by: Tien Fong Chee <tien.fong.chee@intel.com>
> >
> > Applied to u-boot/master, thanks!
>
> please remove this patch (better both of them because they were in
> series) because they are breaking at least ZynqMP SPL. It is also too
> late in cycle to create random fix.
>
> You can't simply move 64KB from code to malloc without reflecting this
> by changing MALLOC space size.
>
> Other boards with SPL fat could be also affected by this if they don't
> allocate big malloc space.
I see from later in on the thread your specific problem is elsewhere.
But to address the root question, we have fairly large malloc
requirements in SPL when FAT is involved as there's a lot of other
mallocs going on there. It's indeed not impossible there's a board that
was on-edge of it's 1MB pool, and now goes over, but that seems
unlikely. Thanks all!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190221/4a914ae2/attachment.sig>
next prev parent reply other threads:[~2019-02-22 3:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 6:56 [U-Boot] [PATCH v3 1/2] fs: fat: dynamically allocate memory for temporary buffer tien.fong.chee at intel.com
2019-02-11 6:56 ` [U-Boot] [PATCH v3 2/2] fs: fat: Reduce default max clustersize 64KiB from malloc pool tien.fong.chee at intel.com
2019-02-20 1:58 ` [U-Boot] [U-Boot, v3, " Tom Rini
2019-02-20 1:58 ` [U-Boot] [U-Boot, v3, 1/2] fs: fat: dynamically allocate memory for temporary buffer Tom Rini
2019-02-21 7:45 ` Michal Simek
2019-02-21 8:23 ` Chee, Tien Fong
2019-02-21 8:29 ` Alexander Graf
2019-02-21 8:40 ` Chee, Tien Fong
2019-02-21 8:41 ` Marek Vasut
2019-02-21 8:44 ` Alexander Graf
2019-02-21 8:49 ` Marek Vasut
2019-02-21 8:55 ` Alexander Graf
2019-02-21 9:04 ` Marek Vasut
2019-02-21 12:13 ` Michal Simek
2019-02-21 12:51 ` Marek Vasut
2019-02-21 13:39 ` Adam Ford
2019-02-22 3:22 ` Tom Rini [this message]
2019-02-22 3:49 ` Chee, Tien Fong
2019-02-22 9:16 ` Michal Simek
2019-02-25 3:33 ` Chee, Tien Fong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190222032200.GO12379@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox