From mboxrd@z Thu Jan  1 00:00:00 1970
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
Date: Mon, 25 Feb 2019 09:36:31 +0900
Subject: [U-Boot] [PATCH v8 4/8] cmd: efidebug: add devices command
In-Reply-To: <9adf3374-68f0-e94a-0e62-654aa8249aeb@gmx.de>
References: <20190222081014.2117-1-takahiro.akashi@linaro.org>
 <20190222081014.2117-5-takahiro.akashi@linaro.org>
 <9adf3374-68f0-e94a-0e62-654aa8249aeb@gmx.de>
Message-ID: <20190225003630.GU20286@linaro.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sat, Feb 23, 2019 at 11:36:53AM +0100, Heinrich Schuchardt wrote:
> On 2/22/19 9:10 AM, AKASHI Takahiro wrote:
> > "devices" command prints all the uefi variables on the system.
> > 
> > => efi devices
> > Scanning disk ahci_scsi.id0lun0...
> > Scanning disk ahci_scsi.id1lun0...
> > Found 4 disks
> > Device           Device Path
> > ================ ====================
> > 000000007ef07ea0 /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)
> > 000000007ef00c10 /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/Scsi(0,0)
> > 000000007ef00dd0 /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/Scsi(1,0)
> > 000000007ef07be0 /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/Scsi(1,0)/HD(1,MBR,0x086246ba,0x800,0x40000)
> > 000000007ef07510 /VenHw(e61d73b9-a384-4acc-aeab-82e828f3628b)/Scsi(1,0)/HD(2,MBR,0x086246ba,0x40800,0x3f800)
> > 
> > Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
> > Reviewed-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> > ---
> 
> When sending patches, please, provide a change history, e.g.
> 
> v8:
> 	no change
> v7:
> 	using EFI_CALL()
> 
> That makes reviewing much easier.

Do you think a change log in my cover letter is not enough?
A per-file change log is good in some cases, and bad in other cases.

-Takahiro Akashi


> Best regards
> 
> Heinrich