From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Rini Date: Thu, 28 Feb 2019 18:55:41 -0500 Subject: [U-Boot] Commit "ARM: CPU: arm926ejs: Consolidate cache routines to common file" breaks u-boot on Dreamplug In-Reply-To: References: Message-ID: <20190228235541.GU12046@bill-the-cat> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Wed, Feb 27, 2019 at 11:32:16AM +0000, Leigh Brown wrote: > Hello, > > Vagrant Cascadian asked for people to test the version of u-boot packaged > for Debian Buster. I tested u-boot on my Dreamplug and found it was not > working correctly. I raised a bug for Debian[1] but I have also tested > with the mainline version of u-boot and found the same issues. > > The first issue is that the following commit caused u-boot to no longer > be able to access usb storage on the Dreamplug: > > commit 93b283d49f933f95f3a6f40762936f454ac655a8 > Author: Adam Ford > Date: Thu Aug 16 13:23:11 2018 -0500 > > ARM: CPU: arm926ejs: Consolidate cache routines to common file > > Four different boards had different options for enabling cache > that were virtually all the same. This consolidates these > common functions into arch/arm/cpu/arm926ejs/cache.c > > This also has the positive side-effect of enabling cache on > the Davinci (da850) boards. > > Signed-off-by: Adam Ford > [trini: Add mach-at91 to the list of consolidations] > Signed-off-by: Tom Rini > > I don't have much knowledge of ARM caching, but the following patch makes > it work again on my Dreamplug. > > diff --git a/arch/arm/mach-kirkwood/cpu.c b/arch/arm/mach-kirkwood/cpu.c > index d54de53f31..8a065d73ae 100644 Thanks for digging into this. Based on the whole thread, yes, this makes sense. Reviewed-by: Tom Rini -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: