From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [U-Boot, 1/1] fs: fat: fix link error when building with DEBUG=1
Date: Thu, 28 Feb 2019 18:56:27 -0500 [thread overview]
Message-ID: <20190228235627.GA12046@bill-the-cat> (raw)
In-Reply-To: <20190225184248.27805-1-xypron.glpk@gmx.de>
On Mon, Feb 25, 2019 at 07:42:48PM +0100, Heinrich Schuchardt wrote:
> When compiling with DEBUG=1 an error
> fs/fat/fat_write.c:831: undefined reference to `__aeabi_ldivmod'
> occurred.
>
> We should use do_div() instead of the modulus operator.
>
> filesize and cur_pos cannot be negative. So let's use u64 to avoid
> warnings.
>
> Fixes: cb8af8af5ba0 ("fs: fat: support write with non-zero offset")
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
Applied to u-boot/master, thanks!
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190228/cd9e3dd5/attachment.sig>
prev parent reply other threads:[~2019-02-28 23:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 18:42 [U-Boot] [PATCH 1/1] fs: fat: fix link error when building with DEBUG=1 Heinrich Schuchardt
2019-02-28 23:56 ` Tom Rini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190228235627.GA12046@bill-the-cat \
--to=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).