From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/1] efi_loader: HII protocols: informative error message
Date: Fri, 1 Mar 2019 10:03:02 +0900 [thread overview]
Message-ID: <20190301010301.GX20286@linaro.org> (raw)
In-Reply-To: <20190228230237.30128-1-xypron.glpk@gmx.de>
On Fri, Mar 01, 2019 at 12:02:37AM +0100, Heinrich Schuchardt wrote:
> When package types are not supported an error message is displayed.
> Unfortunately there is no hint in the messages that they concern the HII
> protocols. Furthermore they are indent by tab for no obvious reason.
I think that I intended to use EFI_PRINT() here, but
printf() is fine for showing informative error messages.
> Prefix the messages by "HII: " instead of "\t".
"EFI HII" would be better?
Thanks,
-Takahiro Akashi
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> lib/efi_loader/efi_hii.c | 36 ++++++++++++++++++------------------
> 1 file changed, 18 insertions(+), 18 deletions(-)
>
> diff --git a/lib/efi_loader/efi_hii.c b/lib/efi_loader/efi_hii.c
> index d63d2d84184..6ee386596a5 100644
> --- a/lib/efi_loader/efi_hii.c
> +++ b/lib/efi_loader/efi_hii.c
> @@ -387,7 +387,7 @@ add_packages(struct efi_hii_packagelist *hii,
> (struct efi_hii_guid_package *)package);
> break;
> case EFI_HII_PACKAGE_FORMS:
> - printf("\tForm package not supported\n");
> + printf("HII: Form package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> break;
> case EFI_HII_PACKAGE_STRINGS:
> @@ -395,19 +395,19 @@ add_packages(struct efi_hii_packagelist *hii,
> (struct efi_hii_strings_package *)package);
> break;
> case EFI_HII_PACKAGE_FONTS:
> - printf("\tFont package not supported\n");
> + printf("HII: Font package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> break;
> case EFI_HII_PACKAGE_IMAGES:
> - printf("\tImage package not supported\n");
> + printf("HII: Image package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> break;
> case EFI_HII_PACKAGE_SIMPLE_FONTS:
> - printf("\tSimple font package not supported\n");
> + printf("HII: Simple font package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> break;
> case EFI_HII_PACKAGE_DEVICE_PATH:
> - printf("\tDevice path package not supported\n");
> + printf("HII: Device path package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> break;
> case EFI_HII_PACKAGE_KEYBOARD_LAYOUT:
> @@ -415,7 +415,7 @@ add_packages(struct efi_hii_packagelist *hii,
> (struct efi_hii_keyboard_package *)package);
> break;
> case EFI_HII_PACKAGE_ANIMATIONS:
> - printf("\tAnimation package not supported\n");
> + printf("HII: Animation package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> break;
> case EFI_HII_PACKAGE_END:
> @@ -522,33 +522,33 @@ update_package_list(const struct efi_hii_database_protocol *this,
> remove_guid_package(hii);
> break;
> case EFI_HII_PACKAGE_FORMS:
> - printf("\tForm package not supported\n");
> + printf("HII: Form package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> break;
> case EFI_HII_PACKAGE_STRINGS:
> remove_strings_package(hii);
> break;
> case EFI_HII_PACKAGE_FONTS:
> - printf("\tFont package not supported\n");
> + printf("HII: Font package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> break;
> case EFI_HII_PACKAGE_IMAGES:
> - printf("\tImage package not supported\n");
> + printf("HII: Image package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> break;
> case EFI_HII_PACKAGE_SIMPLE_FONTS:
> - printf("\tSimple font package not supported\n");
> + printf("HII: Simple font package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> break;
> case EFI_HII_PACKAGE_DEVICE_PATH:
> - printf("\tDevice path package not supported\n");
> + printf("HII: Device path package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> break;
> case EFI_HII_PACKAGE_KEYBOARD_LAYOUT:
> remove_keyboard_package(hii);
> break;
> case EFI_HII_PACKAGE_ANIMATIONS:
> - printf("\tAnimation package not supported\n");
> + printf("HII: Animation package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> break;
> case EFI_HII_PACKAGE_END:
> @@ -609,7 +609,7 @@ list_package_lists(const struct efi_hii_database_protocol *this,
> break;
> continue;
> case EFI_HII_PACKAGE_FORMS:
> - printf("\tForm package not supported\n");
> + printf("HII: Form package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> continue;
> case EFI_HII_PACKAGE_STRINGS:
> @@ -617,19 +617,19 @@ list_package_lists(const struct efi_hii_database_protocol *this,
> break;
> continue;
> case EFI_HII_PACKAGE_FONTS:
> - printf("\tFont package not supported\n");
> + printf("HII: Font package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> continue;
> case EFI_HII_PACKAGE_IMAGES:
> - printf("\tImage package not supported\n");
> + printf("HII: Image package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> continue;
> case EFI_HII_PACKAGE_SIMPLE_FONTS:
> - printf("\tSimple font package not supported\n");
> + printf("HII: Simple font package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> continue;
> case EFI_HII_PACKAGE_DEVICE_PATH:
> - printf("\tDevice path package not supported\n");
> + printf("HII: Device path package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> continue;
> case EFI_HII_PACKAGE_KEYBOARD_LAYOUT:
> @@ -637,7 +637,7 @@ list_package_lists(const struct efi_hii_database_protocol *this,
> break;
> continue;
> case EFI_HII_PACKAGE_ANIMATIONS:
> - printf("\tAnimation package not supported\n");
> + printf("HII: Animation package not supported\n");
> ret = EFI_INVALID_PARAMETER;
> continue;
> case EFI_HII_PACKAGE_END:
> --
> 2.20.1
>
prev parent reply other threads:[~2019-03-01 1:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 23:02 [U-Boot] [PATCH 1/1] efi_loader: HII protocols: informative error message Heinrich Schuchardt
2019-03-01 1:03 ` AKASHI Takahiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190301010301.GX20286@linaro.org \
--to=takahiro.akashi@linaro.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox