public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v4 1/9] adc: exynos-adc: Fix wrong bit operation used to stop the ADC
Date: Tue,  5 Mar 2019 20:57:54 +0100	[thread overview]
Message-ID: <20190305195802.14397-2-krzk@kernel.org> (raw)
In-Reply-To: <20190305195802.14397-1-krzk@kernel.org>

When stopping the ADC_V2_CON1_STC_EN should be cleared.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Lukasz Majewski <lukma@denx.de>
Tested-by: Anand Moon <linux.amoon@gmail.com>
---
 drivers/adc/exynos-adc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/adc/exynos-adc.c b/drivers/adc/exynos-adc.c
index d33e3d632afc..12c49fc8cefb 100644
--- a/drivers/adc/exynos-adc.c
+++ b/drivers/adc/exynos-adc.c
@@ -62,7 +62,7 @@ int exynos_adc_stop(struct udevice *dev)
 
 	/* Stop conversion */
 	cfg = readl(&regs->con1);
-	cfg |= ~ADC_V2_CON1_STC_EN;
+	cfg &= ~ADC_V2_CON1_STC_EN;
 
 	writel(cfg, &regs->con1);
 
-- 
2.17.1

  reply	other threads:[~2019-03-05 19:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20190305200133epcas1p2a0d09fc327298646ae949a1bda4806bd@epcas1p2.samsung.com>
2019-03-05 19:57 ` [U-Boot] [PATCH v4 0/9] arm: exynos: Fix reboot on Odroid HC1 Krzysztof Kozlowski
2019-03-05 19:57   ` Krzysztof Kozlowski [this message]
2019-03-05 19:57   ` [U-Boot] [PATCH v4 2/9] power: regulator: s2mps11: Fix step for LDO27 and LDO35 Krzysztof Kozlowski
2019-03-05 19:57   ` [U-Boot] [PATCH v4 3/9] arm: exynos: Detect revision later, when all resources are ready Krzysztof Kozlowski
2019-03-05 19:57   ` [U-Boot] [PATCH v4 4/9] arm: exynos: odroid-xu3: Display info late to have proper type Krzysztof Kozlowski
2019-03-05 19:57   ` [U-Boot] [PATCH v4 5/9] arm: exynos: Wait till ADC stabilizes before checking Odroid HC1 revision Krzysztof Kozlowski
2019-03-05 19:57   ` [U-Boot] [PATCH v4 6/9] regulator: Add support for ramp delay Krzysztof Kozlowski
2019-03-05 19:58   ` [U-Boot] [PATCH v4 7/9] power: regulator: s2mps11: Add enable delay Krzysztof Kozlowski
2019-03-05 19:58   ` [U-Boot] [PATCH v4 8/9] arm: dts: exynos: Add supply for ADC block to Odroid XU3 family Krzysztof Kozlowski
2019-03-05 19:58   ` [U-Boot] [PATCH v4 9/9] arm: dts: exynos: Add ramp delay property to LDO regulators " Krzysztof Kozlowski
2019-03-06  7:03   ` [U-Boot] [PATCH v4 0/9] arm: exynos: Fix reboot on Odroid HC1 Minkyu Kang
2019-03-06  7:29     ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190305195802.14397-2-krzk@kernel.org \
    --to=krzk@kernel.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox