From: Eugeniu Rosca <roscaeugeniu@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v3 1/7] cmd: part: Add 'number' sub-command
Date: Sun, 10 Mar 2019 23:41:54 +0100 [thread overview]
Message-ID: <20190310224154.GA25918@x230> (raw)
In-Reply-To: <1550506917-25547-2-git-send-email-igor.opaniuk@linaro.org>
Hi Igor,
On Mon, Feb 18, 2019 at 06:21:51PM +0200, Igor Opaniuk wrote:
> From: Ruslan Trofymenko <ruslan.trofymenko@linaro.org>
>
> This sub-command serves for getting the partition index from
> partition name.
[..]
> CMD_PART_INFO_SIZE,
> + CMD_PART_INFO_NUMBER
IMHO 's/number/index/' (when referring to the id of a partition) would
make code and documentation more clear since 'number' can be confused
with 'count' while 'index' is unequivocal.
Feel free to ignore it though, as the terms seem to be intermixed in
various places of Linux/U-Boot (my opinion still stands).
The review comment also applies to other patches from this series:
- https://patchwork.ozlabs.org/patch/1044153/ ("[U-Boot,v3,2/7] disk:
part: Extend API to get partition info")
- https://patchwork.ozlabs.org/patch/1044162/ ("[U-Boot,v3,6/7] doc:
android: Add simple guide for A/B updates")
- https://patchwork.ozlabs.org/patch/1044160/ ("[U-Boot,v3,7/7] env:
am57xx: Implement A/B boot process")
Best regards,
Eugeniu.
next prev parent reply other threads:[~2019-03-10 22:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 16:21 [U-Boot] [PATCH v3 0/7] android: implement A/B boot process Igor Opaniuk
2019-02-18 16:21 ` [U-Boot] [PATCH v3 1/7] cmd: part: Add 'number' sub-command Igor Opaniuk
2019-03-10 22:41 ` Eugeniu Rosca [this message]
2019-03-21 15:42 ` Igor Opaniuk
2019-05-20 13:27 ` Igor Opaniuk
2019-05-20 14:12 ` Roman Stratiienko
2019-02-18 16:21 ` [U-Boot] [PATCH v3 2/7] disk: part: Extend API to get partition info Igor Opaniuk
2019-02-18 16:21 ` [U-Boot] [PATCH v3 3/7] common: Implement A/B metadata Igor Opaniuk
2019-03-08 17:28 ` Eugeniu Rosca
2019-03-21 15:39 ` Igor Opaniuk
2019-03-28 16:30 ` Eugeniu Rosca
2019-03-28 19:58 ` Tom Rini
2019-03-29 8:36 ` Eugeniu Rosca
2019-03-10 21:50 ` Simon Glass
2019-03-11 17:27 ` Eugeniu Rosca
2019-03-18 18:04 ` Eugeniu Rosca
2019-03-18 20:21 ` Eugeniu Rosca
2019-03-18 21:20 ` Bajjuri, Praneeth
2019-03-19 10:13 ` Eugeniu Rosca
2019-02-18 16:21 ` [U-Boot] [PATCH v3 4/7] cmd: Add 'ab_select' command Igor Opaniuk
2019-03-10 21:50 ` Simon Glass
2019-02-18 16:21 ` [U-Boot] [PATCH v3 5/7] test/py: Add base test case for A/B updates Igor Opaniuk
2019-02-18 16:21 ` [U-Boot] [PATCH v3 6/7] doc: android: Add simple guide " Igor Opaniuk
2019-02-18 16:21 ` [U-Boot] [PATCH v3 7/7] env: am57xx: Implement A/B boot process Igor Opaniuk
2019-03-10 21:50 ` Simon Glass
2019-02-28 10:28 ` [U-Boot] [PATCH v3 0/7] android: implement " Sam Protsenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190310224154.GA25918@x230 \
--to=roscaeugeniu@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox