[U-Boot] [PATCH 4/6] fdtdec: Implement fdtdec_add_reserved_memory()

Simon Glass
2019-03-19T01:24:52Z

Hi Thierry,

On Mon, 11 Mar 2019 at 18:06, Thierry Reding <thierry.reding@gmail.com> wrote:
>
> On Sun, Mar 10, 2019 at 03:51:42PM -0600, Simon Glass wrote:
> > On Fri, 8 Mar 2019 at 13:11, Thierry Reding <thierry.reding@gmail.com> wrote:
> > >
> > > From: Thierry Reding <treding@nvidia.com>
> > >
> > > This function can be used to add subnodes in the /reserved-memory node.
> > >
> > > Signed-off-by: Thierry Reding <treding@nvidia.com>
> > > ---
> > > include/fdtdec.h | 17 +++++
> > > lib/fdtdec.c | 158 +++++++++++++++++++++++++++++++++++++++++++++++
> > > 2 files changed, 175 insertions(+)
> > >
> >
> > I think an example would be useful, or perhaps a pointer to some docs
> > (perhaps DT spec?) showing how this function is used?
>
> Yeah, I can add a pointer to the DT bindings. Do you want me to add a
> copy of the DT bindings to the U-Boot source tree, or is it sufficient
> to refer to the docs in Linux?

We should have a copy.

>
> As for an example, patches 5 and 6 show how this should be used. Do you
> want an additional example in the comment, or what did you have in mind?

I was thinking of having an example of a node created by this
function, in the header-file comment.

Regards,
Simon