[U-Boot] [PATCH v1] colibri_vf: fix ethernet by adding explicit phy node

Hannes Schmelzer
2019-03-29T05:54:48Z

Marcel Ziswiler <marcel@ziswiler.com> schrieb am 28.03.2019 23:24:50:

> Von: Marcel Ziswiler <marcel@ziswiler.com>
> An: u-boot at lists.denx.de
> Kopie: Hannes Schmelzer <hannes.schmelzer@br-automation.com>, Marcel
Ziswiler
> <marcel.ziswiler@toradex.com>, Albert Aribaud
<albert.u.boot@aribaud.net>,
> Stefan Agner <stefan.agner@toradex.com>
> Datum: 28.03.2019 23:25
> Betreff: [PATCH v1] colibri_vf: fix ethernet by adding explicit phy node
>
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> The implicit fallback mechanism for searching the whole MDIO bus for at
> least one PHY has been gone with the following commit b882005a18de
> ("drivers/net/fec: phy_init: remove redundant logic"). This lead to the
> Ethernet driver erroring out as follows:
>
> Net: Could not get PHY for FEC0: addr -19
> eth-1: fec at 400d1000
> Colibri VFxx # dhcp
> Could not get PHY for FEC0: addr -19
> Could not get PHY for FEC0: addr -19
> Could not get PHY for FEC0: addr -19
> Could not get PHY for FEC0: addr -19
> No ethernet found.
> Could not get PHY for FEC0: addr -19
> Colibri VFxx #
>
> This commit adds an explicit PHY node which makes it work again.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---

Looks good to me,
now the hardware is fully defined, which should be the normal case.

I will provide today a patch which "brings back" the fallback mechanism
within the
"phy-subsystem". This should be the starting point for the disussion if we
need such
fallback or if we want describe our hardware.

Reviewed-by: Hannes Schmelzer <hannes.schmelzer@br-automation.com>