From: Marek Vasut <marek.vasut@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/5] test/py: mmc: Factor out device selection
Date: Wed, 13 Mar 2019 17:49:25 +0100 [thread overview]
Message-ID: <20190313164929.32753-1-marek.vasut+renesas@gmail.com> (raw)
Factor out the 'mmc dev' call so it can be recycled by other tests.
Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Tom Rini <trini@konsulko.com>
Cc: Simon Glass <sjg@chromium.org>
---
test/py/tests/test_mmc_rd.py | 38 +++++++++++++++++++++++++-----------
1 file changed, 27 insertions(+), 11 deletions(-)
diff --git a/test/py/tests/test_mmc_rd.py b/test/py/tests/test_mmc_rd.py
index a13bc0a5f6..40ae1a8459 100644
--- a/test/py/tests/test_mmc_rd.py
+++ b/test/py/tests/test_mmc_rd.py
@@ -57,6 +57,32 @@ env__mmc_rd_configs = (
)
"""
+def mmc_dev(u_boot_console, is_emmc, devid, partid):
+ """Run the "mmc dev" command.
+
+ Args:
+ u_boot_console: A U-Boot console connection.
+ is_emmc: Whether the device is eMMC
+ devid: Device ID
+ partid: Partition ID
+
+ Returns:
+ Nothing.
+ """
+
+ # Select MMC device
+ cmd = 'mmc dev %d' % devid
+ if is_emmc:
+ cmd += ' %d' % partid
+ response = u_boot_console.run_command(cmd)
+ assert 'no card present' not in response
+ if is_emmc:
+ partid_response = '(part %d)' % partid
+ else:
+ partid_response = ''
+ good_response = 'mmc%d%s is current device' % (devid, partid_response)
+ assert good_response in response
+
@pytest.mark.buildconfigspec('cmd_mmc')
def test_mmc_rd(u_boot_console, env__mmc_rd_config):
"""Test the "mmc read" command.
@@ -86,17 +112,7 @@ def test_mmc_rd(u_boot_console, env__mmc_rd_config):
addr = '0x%08x' % ram_base
# Select MMC device
- cmd = 'mmc dev %d' % devid
- if is_emmc:
- cmd += ' %d' % partid
- response = u_boot_console.run_command(cmd)
- assert 'no card present' not in response
- if is_emmc:
- partid_response = '(part %d)' % partid
- else:
- partid_response = ''
- good_response = 'mmc%d%s is current device' % (devid, partid_response)
- assert good_response in response
+ mmc_dev(u_boot_console, is_emmc, devid, partid)
# Clear target RAM
if expected_crc32:
--
2.20.1
next reply other threads:[~2019-03-13 16:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 16:49 Marek Vasut [this message]
2019-03-13 16:49 ` [U-Boot] [PATCH 2/5] test/py: mmc: Add 'mmc dev' test Marek Vasut
2019-03-19 1:23 ` Simon Glass
2019-04-10 12:20 ` [U-Boot] [U-Boot,2/5] " Tom Rini
2019-03-13 16:49 ` [U-Boot] [PATCH 3/5] test/py: mmc: Add 'mmc rescan' test Marek Vasut
2019-03-19 1:23 ` Simon Glass
2019-04-10 12:20 ` [U-Boot] [U-Boot,3/5] " Tom Rini
2019-03-13 16:49 ` [U-Boot] [PATCH 4/5] test/py: mmc: Add 'mmc info' test Marek Vasut
2019-03-19 1:23 ` Simon Glass
2019-04-10 12:20 ` [U-Boot] [U-Boot,4/5] " Tom Rini
2019-03-13 16:49 ` [U-Boot] [PATCH 5/5] test/py: mmc: Add 'mmc read' performance check Marek Vasut
2019-03-19 1:23 ` Simon Glass
2019-04-10 12:20 ` [U-Boot] [U-Boot, " Tom Rini
2019-03-19 1:23 ` [U-Boot] [PATCH 1/5] test/py: mmc: Factor out device selection Simon Glass
2019-04-10 12:20 ` [U-Boot] [U-Boot, " Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190313164929.32753-1-marek.vasut+renesas@gmail.com \
--to=marek.vasut@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox