public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Lukasz Majewski <lukma@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT"
Date: Mon, 18 Mar 2019 08:23:02 +0100	[thread overview]
Message-ID: <20190318082302.23239082@jawa> (raw)
In-Reply-To: <9a151f7e-2553-0d55-129d-dc550937e6cc@gmail.com>

On Fri, 15 Mar 2019 20:02:25 +0100
Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> wrote:

> Tom,
> 
> (adding Lukasz as he authored the DM fix 0c07a9b4078d)
> 
> Am 14.03.2019 um 21:57 schrieb Simon Goldschmidt:
> > This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51.
> > 
> > The 'eeprom' command has been converted to work with DM_I2C in a
> > patch submitted around the same time as this commit:
> > commit 0c07a9b4078d ("eeprom: Add device model based I2C support to
> > eeprom command")
> > 
> > Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>  
> 
> I know it's late in the release cycle, but is there a chance to get
> this in for v2019.04?
> 
> That would allow me to convert I2C and EEPROM access for socfpga in
> the socfpga-next tree...
> 
> Also, I guess adding this now shouldn't be a great risk since it is 
> default off and removing the dependency shouldn't harm.

If it doesn't cause build breaks - I don't mind.

> 
> Thanks,
> Simon
> 
> > ---
> > 
> >   cmd/Kconfig | 1 -
> >   1 file changed, 1 deletion(-)
> > 
> > diff --git a/cmd/Kconfig b/cmd/Kconfig
> > index 4bcc5c4557..74c5a1a6ed 100644
> > --- a/cmd/Kconfig
> > +++ b/cmd/Kconfig
> > @@ -455,7 +455,6 @@ config CRC32_VERIFY
> >   
> >   config CMD_EEPROM
> >   	bool "eeprom - EEPROM subsystem"
> > -	depends on !DM_I2C || DM_I2C_COMPAT
> >   	help
> >   	  (deprecated, needs conversion to driver model)
> >   	  Provides commands to read and write EEPROM
> > (Electrically Erasable 
> 




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 488 bytes
Desc: OpenPGP digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190318/45cf1354/attachment.sig>

  reply	other threads:[~2019-03-18  7:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-14 20:57 [U-Boot] [PATCH] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT" Simon Goldschmidt
2019-03-15  6:44 ` Michal Simek
2019-03-15  6:51   ` Simon Goldschmidt
2019-03-15  6:57     ` Michal Simek
2019-03-15 19:02 ` Simon Goldschmidt
2019-03-18  7:23   ` Lukasz Majewski [this message]
2019-03-21 19:21     ` Simon Goldschmidt
2019-03-21 20:04       ` Simon Goldschmidt
2019-03-25 15:43 ` [U-Boot] " Tom Rini
2019-03-25 16:42   ` Simon Goldschmidt
2019-03-25 17:17     ` Tom Rini
2019-03-25 20:20       ` Simon Goldschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190318082302.23239082@jawa \
    --to=lukma@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox