* [U-Boot] [PATCH] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT"
@ 2019-03-14 20:57 Simon Goldschmidt
2019-03-15 6:44 ` Michal Simek
` (2 more replies)
0 siblings, 3 replies; 12+ messages in thread
From: Simon Goldschmidt @ 2019-03-14 20:57 UTC (permalink / raw)
To: u-boot
This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51.
The 'eeprom' command has been converted to work with DM_I2C in a patch
submitted around the same time as this commit:
commit 0c07a9b4078d ("eeprom: Add device model based I2C support to eeprom command")
Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
---
cmd/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/cmd/Kconfig b/cmd/Kconfig
index 4bcc5c4557..74c5a1a6ed 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -455,7 +455,6 @@ config CRC32_VERIFY
config CMD_EEPROM
bool "eeprom - EEPROM subsystem"
- depends on !DM_I2C || DM_I2C_COMPAT
help
(deprecated, needs conversion to driver model)
Provides commands to read and write EEPROM (Electrically Erasable
--
2.17.1
^ permalink raw reply related [flat|nested] 12+ messages in thread* [U-Boot] [PATCH] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT" 2019-03-14 20:57 [U-Boot] [PATCH] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT" Simon Goldschmidt @ 2019-03-15 6:44 ` Michal Simek 2019-03-15 6:51 ` Simon Goldschmidt 2019-03-15 19:02 ` Simon Goldschmidt 2019-03-25 15:43 ` [U-Boot] " Tom Rini 2 siblings, 1 reply; 12+ messages in thread From: Michal Simek @ 2019-03-15 6:44 UTC (permalink / raw) To: u-boot On 14. 03. 19 21:57, Simon Goldschmidt wrote: > This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. You should also put subject of that patch here. It is much easier to check what was that. M ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT" 2019-03-15 6:44 ` Michal Simek @ 2019-03-15 6:51 ` Simon Goldschmidt 2019-03-15 6:57 ` Michal Simek 0 siblings, 1 reply; 12+ messages in thread From: Simon Goldschmidt @ 2019-03-15 6:51 UTC (permalink / raw) To: u-boot On Fri, Mar 15, 2019 at 7:44 AM Michal Simek <michal.simek@xilinx.com> wrote: > > On 14. 03. 19 21:57, Simon Goldschmidt wrote: > > This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. > > You should also put subject of that patch here. It is much easier to > check what was that. The subject of the commit is in the patch's subject line, isn't that enough? Regards, Simon ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT" 2019-03-15 6:51 ` Simon Goldschmidt @ 2019-03-15 6:57 ` Michal Simek 0 siblings, 0 replies; 12+ messages in thread From: Michal Simek @ 2019-03-15 6:57 UTC (permalink / raw) To: u-boot On 15. 03. 19 7:51, Simon Goldschmidt wrote: > On Fri, Mar 15, 2019 at 7:44 AM Michal Simek <michal.simek@xilinx.com> wrote: >> >> On 14. 03. 19 21:57, Simon Goldschmidt wrote: >>> This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. >> >> You should also put subject of that patch here. It is much easier to >> check what was that. > > The subject of the commit is in the patch's subject line, isn't that enough? I missed that - it is fine. :-) It is Friday. Cheers, Michal ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT" 2019-03-14 20:57 [U-Boot] [PATCH] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT" Simon Goldschmidt 2019-03-15 6:44 ` Michal Simek @ 2019-03-15 19:02 ` Simon Goldschmidt 2019-03-18 7:23 ` Lukasz Majewski 2019-03-25 15:43 ` [U-Boot] " Tom Rini 2 siblings, 1 reply; 12+ messages in thread From: Simon Goldschmidt @ 2019-03-15 19:02 UTC (permalink / raw) To: u-boot Tom, (adding Lukasz as he authored the DM fix 0c07a9b4078d) Am 14.03.2019 um 21:57 schrieb Simon Goldschmidt: > This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. > > The 'eeprom' command has been converted to work with DM_I2C in a patch > submitted around the same time as this commit: > commit 0c07a9b4078d ("eeprom: Add device model based I2C support to eeprom command") > > Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> I know it's late in the release cycle, but is there a chance to get this in for v2019.04? That would allow me to convert I2C and EEPROM access for socfpga in the socfpga-next tree... Also, I guess adding this now shouldn't be a great risk since it is default off and removing the dependency shouldn't harm. Thanks, Simon > --- > > cmd/Kconfig | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/cmd/Kconfig b/cmd/Kconfig > index 4bcc5c4557..74c5a1a6ed 100644 > --- a/cmd/Kconfig > +++ b/cmd/Kconfig > @@ -455,7 +455,6 @@ config CRC32_VERIFY > > config CMD_EEPROM > bool "eeprom - EEPROM subsystem" > - depends on !DM_I2C || DM_I2C_COMPAT > help > (deprecated, needs conversion to driver model) > Provides commands to read and write EEPROM (Electrically Erasable > ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT" 2019-03-15 19:02 ` Simon Goldschmidt @ 2019-03-18 7:23 ` Lukasz Majewski 2019-03-21 19:21 ` Simon Goldschmidt 0 siblings, 1 reply; 12+ messages in thread From: Lukasz Majewski @ 2019-03-18 7:23 UTC (permalink / raw) To: u-boot On Fri, 15 Mar 2019 20:02:25 +0100 Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> wrote: > Tom, > > (adding Lukasz as he authored the DM fix 0c07a9b4078d) > > Am 14.03.2019 um 21:57 schrieb Simon Goldschmidt: > > This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. > > > > The 'eeprom' command has been converted to work with DM_I2C in a > > patch submitted around the same time as this commit: > > commit 0c07a9b4078d ("eeprom: Add device model based I2C support to > > eeprom command") > > > > Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> > > I know it's late in the release cycle, but is there a chance to get > this in for v2019.04? > > That would allow me to convert I2C and EEPROM access for socfpga in > the socfpga-next tree... > > Also, I guess adding this now shouldn't be a great risk since it is > default off and removing the dependency shouldn't harm. If it doesn't cause build breaks - I don't mind. > > Thanks, > Simon > > > --- > > > > cmd/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/cmd/Kconfig b/cmd/Kconfig > > index 4bcc5c4557..74c5a1a6ed 100644 > > --- a/cmd/Kconfig > > +++ b/cmd/Kconfig > > @@ -455,7 +455,6 @@ config CRC32_VERIFY > > > > config CMD_EEPROM > > bool "eeprom - EEPROM subsystem" > > - depends on !DM_I2C || DM_I2C_COMPAT > > help > > (deprecated, needs conversion to driver model) > > Provides commands to read and write EEPROM > > (Electrically Erasable > Best regards, Lukasz Majewski -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 488 bytes Desc: OpenPGP digital signature URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190318/45cf1354/attachment.sig> ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT" 2019-03-18 7:23 ` Lukasz Majewski @ 2019-03-21 19:21 ` Simon Goldschmidt 2019-03-21 20:04 ` Simon Goldschmidt 0 siblings, 1 reply; 12+ messages in thread From: Simon Goldschmidt @ 2019-03-21 19:21 UTC (permalink / raw) To: u-boot Hi Lukasz, Am 18.03.2019 um 08:23 schrieb Lukasz Majewski: > On Fri, 15 Mar 2019 20:02:25 +0100 > Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> wrote: > >> Tom, >> >> (adding Lukasz as he authored the DM fix 0c07a9b4078d) >> >> Am 14.03.2019 um 21:57 schrieb Simon Goldschmidt: >>> This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. >>> >>> The 'eeprom' command has been converted to work with DM_I2C in a >>> patch submitted around the same time as this commit: >>> commit 0c07a9b4078d ("eeprom: Add device model based I2C support to >>> eeprom command") >>> >>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> >> >> I know it's late in the release cycle, but is there a chance to get >> this in for v2019.04? >> >> That would allow me to convert I2C and EEPROM access for socfpga in >> the socfpga-next tree... >> >> Also, I guess adding this now shouldn't be a great risk since it is >> default off and removing the dependency shouldn't harm. > > If it doesn't cause build breaks - I don't mind. I don't see why this should cause build breaks. It's default off and not selected anywhere: although 101 defconfig files have CONFIG_CMD_EEPROM enabled, none of them has CONFIG_DM_I2C enabled. Your patch from Nov/Dec 2018 should allow those boards to move to DM_I2C (if the i2c driver supports it) but the commit I want to revert here prevents it soemwhat by depending on legacy code: even DM_I2C_COMPAT is not needed any more after your patch. Regards, Simon > >> >> Thanks, >> Simon >> >>> --- >>> >>> cmd/Kconfig | 1 - >>> 1 file changed, 1 deletion(-) >>> >>> diff --git a/cmd/Kconfig b/cmd/Kconfig >>> index 4bcc5c4557..74c5a1a6ed 100644 >>> --- a/cmd/Kconfig >>> +++ b/cmd/Kconfig >>> @@ -455,7 +455,6 @@ config CRC32_VERIFY >>> >>> config CMD_EEPROM >>> bool "eeprom - EEPROM subsystem" >>> - depends on !DM_I2C || DM_I2C_COMPAT >>> help >>> (deprecated, needs conversion to driver model) >>> Provides commands to read and write EEPROM >>> (Electrically Erasable >> > > > > > Best regards, > > Lukasz Majewski > > -- > > DENX Software Engineering GmbH, Managing Director: Wolfgang Denk > HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany > Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de > ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT" 2019-03-21 19:21 ` Simon Goldschmidt @ 2019-03-21 20:04 ` Simon Goldschmidt 0 siblings, 0 replies; 12+ messages in thread From: Simon Goldschmidt @ 2019-03-21 20:04 UTC (permalink / raw) To: u-boot Tom, Am 21.03.2019 um 20:21 schrieb Simon Goldschmidt: > Hi Lukasz, > > Am 18.03.2019 um 08:23 schrieb Lukasz Majewski: >> On Fri, 15 Mar 2019 20:02:25 +0100 >> Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> wrote: >> >>> Tom, >>> >>> (adding Lukasz as he authored the DM fix 0c07a9b4078d) >>> >>> Am 14.03.2019 um 21:57 schrieb Simon Goldschmidt: >>>> This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. >>>> >>>> The 'eeprom' command has been converted to work with DM_I2C in a >>>> patch submitted around the same time as this commit: >>>> commit 0c07a9b4078d ("eeprom: Add device model based I2C support to >>>> eeprom command") >>>> >>>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> >>> >>> I know it's late in the release cycle, but is there a chance to get >>> this in for v2019.04? >>> >>> That would allow me to convert I2C and EEPROM access for socfpga in >>> the socfpga-next tree... >>> >>> Also, I guess adding this now shouldn't be a great risk since it is >>> default off and removing the dependency shouldn't harm. >> >> If it doesn't cause build breaks - I don't mind. > > I don't see why this should cause build breaks. It's default off and not > selected anywhere: although 101 defconfig files have CONFIG_CMD_EEPROM > enabled, none of them has CONFIG_DM_I2C enabled. > > Your patch from Nov/Dec 2018 should allow those boards to move to DM_I2C > (if the i2c driver supports it) but the commit I want to revert here > prevents it soemwhat by depending on legacy code: even DM_I2C_COMPAT is > not needed any more after your patch. Could this please go in to v2019.04? I'd like to base my patches for socfpga-next on this... Or should Heiko get this via the i2c tree? Regards, Simon > > Regards, > Simon > >> >>> >>> Thanks, >>> Simon >>> >>>> --- >>>> >>>> cmd/Kconfig | 1 - >>>> 1 file changed, 1 deletion(-) >>>> >>>> diff --git a/cmd/Kconfig b/cmd/Kconfig >>>> index 4bcc5c4557..74c5a1a6ed 100644 >>>> --- a/cmd/Kconfig >>>> +++ b/cmd/Kconfig >>>> @@ -455,7 +455,6 @@ config CRC32_VERIFY >>>> >>>> config CMD_EEPROM >>>> bool "eeprom - EEPROM subsystem" >>>> - depends on !DM_I2C || DM_I2C_COMPAT >>>> help >>>> (deprecated, needs conversion to driver model) >>>> Provides commands to read and write EEPROM >>>> (Electrically Erasable >>> >> >> >> >> >> Best regards, >> >> Lukasz Majewski >> >> -- >> >> DENX Software Engineering GmbH, Managing Director: Wolfgang Denk >> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany >> Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma at denx.de >> > ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT" 2019-03-14 20:57 [U-Boot] [PATCH] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT" Simon Goldschmidt 2019-03-15 6:44 ` Michal Simek 2019-03-15 19:02 ` Simon Goldschmidt @ 2019-03-25 15:43 ` Tom Rini 2019-03-25 16:42 ` Simon Goldschmidt 2 siblings, 1 reply; 12+ messages in thread From: Tom Rini @ 2019-03-25 15:43 UTC (permalink / raw) To: u-boot On Thu, Mar 14, 2019 at 09:57:42PM +0100, Simon Goldschmidt wrote: > This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. > > The 'eeprom' command has been converted to work with DM_I2C in a patch > submitted around the same time as this commit: > commit 0c07a9b4078d ("eeprom: Add device model based I2C support to eeprom command") > > Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> > --- > > cmd/Kconfig | 1 - > 1 file changed, 1 deletion(-) As is, nope: make O=/home/jenkins/u-boot/build-am335x_evm -s am335x_evm_defconfig make O=/home/jenkins/u-boot/build-am335x_evm -s -j8 ../cmd/eeprom.c: In function 'eeprom_rw_block': ../cmd/eeprom.c:149:9: warning: implicit declaration of function 'i2c_read'; did you mean 'ide_read'? [-Wimplicit-function-declaration] ret = i2c_read(addr[0], offset, alen - 1, buffer, len); ^~~~~~~~ ide_read ../cmd/eeprom.c:151:9: warning: implicit declaration of function 'i2c_write'; did you mean 'ide_write'? [-Wimplicit-function-declaration] ret = i2c_write(addr[0], offset, alen - 1, buffer, len); ^~~~~~~~~ ide_write cmd/built-in.o: In function `eeprom_rw_block': /home/jenkins/u-boot/build-am335x_evm/../cmd/eeprom.c:149: undefined reference to `i2c_read' /home/jenkins/u-boot/build-am335x_evm/../cmd/eeprom.c:151: undefined reference to `i2c_write' /home/jenkins/u-boot/Makefile:1497: recipe for target 'u-boot' failed make[1]: *** [u-boot] Error 1 Makefile:148: recipe for target 'sub-make' failed make: *** [sub-make] Error 2 -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190325/d596d293/attachment.sig> ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT" 2019-03-25 15:43 ` [U-Boot] " Tom Rini @ 2019-03-25 16:42 ` Simon Goldschmidt 2019-03-25 17:17 ` Tom Rini 0 siblings, 1 reply; 12+ messages in thread From: Simon Goldschmidt @ 2019-03-25 16:42 UTC (permalink / raw) To: u-boot Tom Rini <trini@konsulko.com> schrieb am Mo., 25. März 2019, 16:43: > On Thu, Mar 14, 2019 at 09:57:42PM +0100, Simon Goldschmidt wrote: > > > This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. > > > > The 'eeprom' command has been converted to work with DM_I2C in a patch > > submitted around the same time as this commit: > > commit 0c07a9b4078d ("eeprom: Add device model based I2C support to > eeprom command") > > > > Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> > > --- > > > > cmd/Kconfig | 1 - > > 1 file changed, 1 deletion(-) > > As is, nope: > make O=/home/jenkins/u-boot/build-am335x_evm -s am335x_evm_defconfig > make O=/home/jenkins/u-boot/build-am335x_evm -s -j8 > ../cmd/eeprom.c: In function 'eeprom_rw_block': > ../cmd/eeprom.c:149:9: warning: implicit declaration of function > 'i2c_read'; did you mean 'ide_read'? [-Wimplicit-function-declaration] > ret = i2c_read(addr[0], offset, alen - 1, buffer, len); > ^~~~~~~~ > ide_read > ../cmd/eeprom.c:151:9: warning: implicit declaration of function > 'i2c_write'; did you mean 'ide_write'? [-Wimplicit-function-declaration] > ret = i2c_write(addr[0], offset, alen - 1, buffer, len); > ^~~~~~~~~ > ide_write > cmd/built-in.o: In function `eeprom_rw_block': > /home/jenkins/u-boot/build-am335x_evm/../cmd/eeprom.c:149: undefined > reference to `i2c_read' > /home/jenkins/u-boot/build-am335x_evm/../cmd/eeprom.c:151: undefined > reference to `i2c_write' > /home/jenkins/u-boot/Makefile:1497: recipe for target 'u-boot' failed > make[1]: *** [u-boot] Error 1 > Makefile:148: recipe for target 'sub-make' failed > make: *** [sub-make] Error 2 > Ehrm, ok, let me check that. Do you have a Travis build with more errors or is this the only one? Regards, Simon ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT" 2019-03-25 16:42 ` Simon Goldschmidt @ 2019-03-25 17:17 ` Tom Rini 2019-03-25 20:20 ` Simon Goldschmidt 0 siblings, 1 reply; 12+ messages in thread From: Tom Rini @ 2019-03-25 17:17 UTC (permalink / raw) To: u-boot On Mon, Mar 25, 2019 at 05:42:13PM +0100, Simon Goldschmidt wrote: > Tom Rini <trini@konsulko.com> schrieb am Mo., 25. März 2019, 16:43: > > > On Thu, Mar 14, 2019 at 09:57:42PM +0100, Simon Goldschmidt wrote: > > > > > This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. > > > > > > The 'eeprom' command has been converted to work with DM_I2C in a patch > > > submitted around the same time as this commit: > > > commit 0c07a9b4078d ("eeprom: Add device model based I2C support to > > eeprom command") > > > > > > Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> > > > --- > > > > > > cmd/Kconfig | 1 - > > > 1 file changed, 1 deletion(-) > > > > As is, nope: > > make O=/home/jenkins/u-boot/build-am335x_evm -s am335x_evm_defconfig > > make O=/home/jenkins/u-boot/build-am335x_evm -s -j8 > > ../cmd/eeprom.c: In function 'eeprom_rw_block': > > ../cmd/eeprom.c:149:9: warning: implicit declaration of function > > 'i2c_read'; did you mean 'ide_read'? [-Wimplicit-function-declaration] > > ret = i2c_read(addr[0], offset, alen - 1, buffer, len); > > ^~~~~~~~ > > ide_read > > ../cmd/eeprom.c:151:9: warning: implicit declaration of function > > 'i2c_write'; did you mean 'ide_write'? [-Wimplicit-function-declaration] > > ret = i2c_write(addr[0], offset, alen - 1, buffer, len); > > ^~~~~~~~~ > > ide_write > > cmd/built-in.o: In function `eeprom_rw_block': > > /home/jenkins/u-boot/build-am335x_evm/../cmd/eeprom.c:149: undefined > > reference to `i2c_read' > > /home/jenkins/u-boot/build-am335x_evm/../cmd/eeprom.c:151: undefined > > reference to `i2c_write' > > /home/jenkins/u-boot/Makefile:1497: recipe for target 'u-boot' failed > > make[1]: *** [u-boot] Error 1 > > Makefile:148: recipe for target 'sub-make' failed > > make: *** [sub-make] Error 2 > > > > Ehrm, ok, let me check that. Do you have a Travis build with more errors or > is this the only one? This was in my local jenkins setup as that's on a board I have and test. There was a travis run but I force-pushed over it to test my branch again. -- Tom -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 819 bytes Desc: not available URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190325/e9a0dccc/attachment.sig> ^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT" 2019-03-25 17:17 ` Tom Rini @ 2019-03-25 20:20 ` Simon Goldschmidt 0 siblings, 0 replies; 12+ messages in thread From: Simon Goldschmidt @ 2019-03-25 20:20 UTC (permalink / raw) To: u-boot On 25.03.19 18:17, Tom Rini wrote: > On Mon, Mar 25, 2019 at 05:42:13PM +0100, Simon Goldschmidt wrote: >> Tom Rini <trini@konsulko.com> schrieb am Mo., 25. März 2019, 16:43: >> >>> On Thu, Mar 14, 2019 at 09:57:42PM +0100, Simon Goldschmidt wrote: >>> >>>> This reverts commit 65a97e7fcf54feb7c4ebe1aee8a572830af4cf51. >>>> >>>> The 'eeprom' command has been converted to work with DM_I2C in a patch >>>> submitted around the same time as this commit: >>>> commit 0c07a9b4078d ("eeprom: Add device model based I2C support to >>> eeprom command") >>>> >>>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt@gmail.com> >>>> --- >>>> >>>> cmd/Kconfig | 1 - >>>> 1 file changed, 1 deletion(-) >>> >>> As is, nope: >>> make O=/home/jenkins/u-boot/build-am335x_evm -s am335x_evm_defconfig >>> make O=/home/jenkins/u-boot/build-am335x_evm -s -j8 >>> ../cmd/eeprom.c: In function 'eeprom_rw_block': >>> ../cmd/eeprom.c:149:9: warning: implicit declaration of function >>> 'i2c_read'; did you mean 'ide_read'? [-Wimplicit-function-declaration] >>> ret = i2c_read(addr[0], offset, alen - 1, buffer, len); >>> ^~~~~~~~ >>> ide_read >>> ../cmd/eeprom.c:151:9: warning: implicit declaration of function >>> 'i2c_write'; did you mean 'ide_write'? [-Wimplicit-function-declaration] >>> ret = i2c_write(addr[0], offset, alen - 1, buffer, len); >>> ^~~~~~~~~ >>> ide_write >>> cmd/built-in.o: In function `eeprom_rw_block': >>> /home/jenkins/u-boot/build-am335x_evm/../cmd/eeprom.c:149: undefined >>> reference to `i2c_read' >>> /home/jenkins/u-boot/build-am335x_evm/../cmd/eeprom.c:151: undefined >>> reference to `i2c_write' >>> /home/jenkins/u-boot/Makefile:1497: recipe for target 'u-boot' failed >>> make[1]: *** [u-boot] Error 1 >>> Makefile:148: recipe for target 'sub-make' failed >>> make: *** [sub-make] Error 2 >>> >> >> Ehrm, ok, let me check that. Do you have a Travis build with more errors or >> is this the only one? > > This was in my local jenkins setup as that's on a board I have and test. > There was a travis run but I force-pushed over it to test my branch > again. OK, so it turns out the current code isn't fully convert cmd/eeprom to DM as the code now still relies on CONFIG_SYS_I2C_EEPROM_BUS being defined. I'll prepare a patch to make it work without that define. Being like that, it's for the next merge window, of course. Regards, Simon ^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-03-25 20:20 UTC | newest] Thread overview: 12+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-03-14 20:57 [U-Boot] [PATCH] Revert "cmd: Kconfig: Do not include EEPROM if DM_I2C is used without DM_I2C_COMPAT" Simon Goldschmidt 2019-03-15 6:44 ` Michal Simek 2019-03-15 6:51 ` Simon Goldschmidt 2019-03-15 6:57 ` Michal Simek 2019-03-15 19:02 ` Simon Goldschmidt 2019-03-18 7:23 ` Lukasz Majewski 2019-03-21 19:21 ` Simon Goldschmidt 2019-03-21 20:04 ` Simon Goldschmidt 2019-03-25 15:43 ` [U-Boot] " Tom Rini 2019-03-25 16:42 ` Simon Goldschmidt 2019-03-25 17:17 ` Tom Rini 2019-03-25 20:20 ` Simon Goldschmidt
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox