[U-Boot] [PATCH 1/2] tools/imx8m_image.sh: remove bashism

Stefano Babic
2019-04-01T15:51:31Z

Hi Fabio, Otavio,

On 01/04/19 16:14, Fabio Estevam wrote:
> Hi Stefano,
>
> On Mon, Apr 1, 2019 at 11:06 AM Stefano Babic <sbabic@denx.de> wrote:
>
>> Well, it looks like too much because I have 18.04, too, and I can build.
>> I cannot say that Ubuntu users cannot build u-boot anymore.
>> I guess you have /bin/sh -> dash, and /bin/sh -> bash solves the
>> problem, too. Or using update-alternatives, as we are in Ubuntu. I can
>> imagine it is disturbing in docker because a further step in
>> docker-compose to set up the shell is required, too.
>> As far as I know, default is dash (but was not dash default a long of
>> time ago ? I wonder this has become an issue recently, I have missed
>> something in the between). Nevertheless, I am still missing why this is
>> so important to push here when the user can set the shell and build
>> without issues. And travis works, too, it is also based on Ubuntu :
>
> Travis does not report an error, but Travis does not try to generate a
> real 'flash.bin' with the required DDR, HDMI and ATF firmwares.
>
> The error comes when we try to generate flash.bin with all these firmwares.
>
> Without Baruch's patch I can not generate a flash.bin that can boot on
> im8mq-evk, so that's why I see the lack of this patch as a big issue.
>

Ok - convinced. I pick it up.

Regards,
Stefano

--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================